View Options

	diff --git a/src/applications/project/remarkup/ProjectRemarkupRule.php b/src/applications/project/remarkup/ProjectRemarkupRule.php
	index 02800ab1a8..9acd489dd6 100644
	--- a/src/applications/project/remarkup/ProjectRemarkupRule.php
	+++ b/src/applications/project/remarkup/ProjectRemarkupRule.php
	@@ -1,50 +1,60 @@
	<?php

	/**
	* @group project
	*/
	final class ProjectRemarkupRule
	extends PhabricatorRemarkupRuleObject {

	protected function getObjectNamePrefix() {
	return '#';
	}

	protected function getObjectIDPattern() {
	// NOTE: This explicitly does not match strings which contain only
	// digits, because digit strings like "#123" are used to reference tasks at
	// Facebook and are somewhat conventional in general.
	return '[^\s.!,:;][^\s\d.!,:;]+[^\s.!,:;]';
	}

	protected function loadObjects(array $ids) {
	$viewer = $this->getEngine()->getConfig('viewer');

	// If the user types "#YoloSwag", we still want to match "#yoloswag", so
	// we normalize, query, and then map back to the original inputs.

	$map = array();
	foreach ($ids as $key => $slug) {
	- $map[PhabricatorSlug::normalize($slug)][] = $slug;
	+ $map[$this->normalizeSlug($slug)][] = $slug;
	}

	$projects = id(new PhabricatorProjectQuery())
	->setViewer($viewer)
	->withPhrictionSlugs(array_keys($map))
	->execute();

	$result = array();
	foreach ($projects as $project) {
	$slugs = array($project->getPhrictionSlug());
	foreach ($slugs as $slug) {
	foreach ($map[$slug] as $original) {
	$result[$original] = $project;
	}
	}
	}


	return $result;
	}

	+ private function normalizeSlug($slug) {
	+ // NOTE: We're using phutil_utf8_strtolower() (and not PhabricatorSlug's
	+ // normalize() method) because this normalization should be only somewhat
	+ // liberal. We want "#YOLO" to match against "#yolo", but "#\\yo!!lo"
	+ // should not. normalize() strips out most punctuation and leads to
	+ // excessively aggressive matches.
	+
	+ return phutil_utf8_strtolower($slug).'/';
	+ }
	+
	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 16:00 (2 w, 6 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1126269
Default Alt Text: (2 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions