No OneTemporary
Actions

Size

23 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/files/engine/PhabricatorTestStorageEngine.php b/src/applications/files/engine/PhabricatorTestStorageEngine.php
	index af45c6574a..0dc2c8757b 100644
	--- a/src/applications/files/engine/PhabricatorTestStorageEngine.php
	+++ b/src/applications/files/engine/PhabricatorTestStorageEngine.php
	@@ -1,36 +1,36 @@
	<?php

	/**
	* Test storage engine. Does not actually store files. Used for unit tests.
	*
	* @group filestorage
	*/
	final class PhabricatorTestStorageEngine
	extends PhabricatorFileStorageEngine {

	private static $storage = array();
	private static $nextHandle = 1;

	public function getEngineIdentifier() {
	return 'unit-test';
	}

	public function writeFile($data, array $params) {
	AphrontWriteGuard::willWrite();
	self::$storage[self::$nextHandle] = $data;
	- return self::$nextHandle++;
	+ return (string)self::$nextHandle++;
	}

	public function readFile($handle) {
	if (isset(self::$storage[$handle])) {
	return self::$storage[$handle];
	}
	throw new Exception("No such file with handle '{$handle}'!");
	}

	public function deleteFile($handle) {
	AphrontWriteGuard::willWrite();
	unset(self::$storage[$handle]);
	}

	}
	diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php
	index 4e28e4d3f0..97b01ecc91 100644
	--- a/src/applications/files/storage/PhabricatorFile.php
	+++ b/src/applications/files/storage/PhabricatorFile.php
	@@ -1,571 +1,633 @@
	<?php

	final class PhabricatorFile extends PhabricatorFileDAO
	implements PhabricatorPolicyInterface {

	const STORAGE_FORMAT_RAW = 'raw';

	const METADATA_IMAGE_WIDTH = 'width';
	const METADATA_IMAGE_HEIGHT = 'height';

	protected $phid;
	protected $name;
	protected $mimeType;
	protected $byteSize;
	protected $authorPHID;
	protected $secretKey;
	protected $contentHash;
	protected $metadata = array();

	protected $storageEngine;
	protected $storageFormat;
	protected $storageHandle;

	public function getConfiguration() {
	return array(
	self::CONFIG_AUX_PHID => true,
	self::CONFIG_SERIALIZATION => array(
	'metadata' => self::SERIALIZATION_JSON,
	),
	) + parent::getConfiguration();
	}

	public function generatePHID() {
	return PhabricatorPHID::generateNewPHID(
	PhabricatorPHIDConstants::PHID_TYPE_FILE);
	}

	public static function readUploadedFileData($spec) {
	if (!$spec) {
	throw new Exception("No file was uploaded!");
	}

	$err = idx($spec, 'error');
	if ($err) {
	throw new PhabricatorFileUploadException($err);
	}

	$tmp_name = idx($spec, 'tmp_name');
	$is_valid = @is_uploaded_file($tmp_name);
	if (!$is_valid) {
	throw new Exception("File is not an uploaded file.");
	}

	$file_data = Filesystem::readFile($tmp_name);
	$file_size = idx($spec, 'size');

	if (strlen($file_data) != $file_size) {
	throw new Exception("File size disagrees with uploaded size.");
	}

	self::validateFileSize(strlen($file_data));

	return $file_data;
	}

	public static function newFromPHPUpload($spec, array $params = array()) {
	$file_data = self::readUploadedFileData($spec);

	$file_name = nonempty(
	idx($params, 'name'),
	idx($spec, 'name'));
	$params = array(
	'name' => $file_name,
	) + $params;

	return self::newFromFileData($file_data, $params);
	}

	public static function newFromXHRUpload($data, array $params = array()) {
	self::validateFileSize(strlen($data));
	return self::newFromFileData($data, $params);
	}

	private static function validateFileSize($size) {
	$limit = PhabricatorEnv::getEnvConfig('storage.upload-size-limit');
	if (!$limit) {
	return;
	}

	$limit = phabricator_parse_bytes($limit);
	if ($size > $limit) {
	throw new PhabricatorFileUploadException(-1000);
	}
	}


	/**
	* Given a block of data, try to load an existing file with the same content
	* if one exists. If it does not, build a new file.
	*
	* This method is generally used when we have some piece of semi-trusted data
	* like a diff or a file from a repository that we want to show to the user.
	* We can't just dump it out because it may be dangerous for any number of
	* reasons; instead, we need to serve it through the File abstraction so it
	* ends up on the CDN domain if one is configured and so on. However, if we
	* simply wrote a new file every time we'd potentially end up with a lot
	* of redundant data in file storage.
	*
	* To solve these problems, we use file storage as a cache and reuse the
	* same file again if we've previously written it.
	*
	* NOTE: This method unguards writes.
	*
	* @param string Raw file data.
	* @param dict Dictionary of file information.
	*/
	public static function buildFromFileDataOrHash(
	$data,
	array $params = array()) {

	$file = id(new PhabricatorFile())->loadOneWhere(
	'name = %s AND contentHash = %s LIMIT 1',
	self::normalizeFileName(idx($params, 'name')),
	PhabricatorHash::digest($data));

	if (!$file) {
	$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
	$file = PhabricatorFile::newFromFileData($data, $params);
	unset($unguarded);
	}

	return $file;
	}

	+ public static function newFileFromContentHash($hash, $params) {

	- public static function newFromFileData($data, array $params = array()) {
	+ // Check to see if a file with same contentHash exist
	+ $file = id(new PhabricatorFile())->loadOneWhere(
	+ 'contentHash = %s LIMIT 1', $hash);
	+
	+ if ($file) {
	+ // copy storageEngine, storageHandle, storageFormat
	+ $copy_of_storage_engine = $file->getStorageEngine();
	+ $copy_of_storage_handle = $file->getStorageHandle();
	+ $copy_of_storage_format = $file->getStorageFormat();
	+ $copy_of_byteSize = $file->getByteSize();
	+ $copy_of_mimeType = $file->getMimeType();
	+
	+ $file_name = idx($params, 'name');
	+ $file_name = self::normalizeFileName($file_name);
	+ $authorPHID = idx($params, 'authorPHID');
	+
	+ $new_file = new PhabricatorFile();
	+
	+ $new_file->setName($file_name);
	+ $new_file->setByteSize($copy_of_byteSize);
	+ $new_file->setAuthorPHID($authorPHID);
	+
	+ $new_file->setContentHash($hash);
	+ $new_file->setStorageEngine($copy_of_storage_engine);
	+ $new_file->setStorageHandle($copy_of_storage_handle);
	+ $new_file->setStorageFormat($copy_of_storage_format);
	+ $new_file->setMimeType($copy_of_mimeType);
	+
	+ $new_file->save();
	+
	+ return $new_file;
	+ }
	+
	+ return $file;
	+ }
	+
	+ private static function buildFromFileData($data, array $params = array()) {
	+ $selector = PhabricatorEnv::newObjectFromConfig('storage.engine-selector');

	if (isset($params['storageEngines'])) {
	$engines = $params['storageEngines'];
	} else {
	$selector = PhabricatorEnv::newObjectFromConfig(
	'storage.engine-selector');
	$engines = $selector->selectStorageEngines($data, $params);
	}

	assert_instances_of($engines, 'PhabricatorFileStorageEngine');
	if (!$engines) {
	throw new Exception("No valid storage engines are available!");
	}

	$file = new PhabricatorFile();

	$data_handle = null;
	$engine_identifier = null;
	$exceptions = array();
	foreach ($engines as $engine) {
	$engine_class = get_class($engine);
	try {
	list($engine_identifier, $data_handle) = $file->writeToEngine(
	$engine,
	$data,
	$params);

	// We stored the file somewhere so stop trying to write it to other
	// places.
	break;
	} catch (PhabricatorFileStorageConfigurationException $ex) {
	// If an engine is outright misconfigured (or misimplemented), raise
	// that immediately since it probably needs attention.
	throw $ex;
	} catch (Exception $ex) {
	phlog($ex);

	// If an engine doesn't work, keep trying all the other valid engines
	// in case something else works.
	$exceptions[$engine_class] = $ex;
	}
	}

	if (!$data_handle) {
	throw new PhutilAggregateException(
	"All storage engines failed to write file:",
	$exceptions);
	}

	$file_name = idx($params, 'name');
	$file_name = self::normalizeFileName($file_name);

	// If for whatever reason, authorPHID isn't passed as a param
	// (always the case with newFromFileDownload()), store a ''
	$authorPHID = idx($params, 'authorPHID');

	$file->setName($file_name);
	$file->setByteSize(strlen($data));
	$file->setAuthorPHID($authorPHID);
	$file->setContentHash(PhabricatorHash::digest($data));

	$file->setStorageEngine($engine_identifier);
	$file->setStorageHandle($data_handle);

	// TODO: This is probably YAGNI, but allows for us to do encryption or
	// compression later if we want.
	$file->setStorageFormat(self::STORAGE_FORMAT_RAW);

	if (isset($params['mime-type'])) {
	$file->setMimeType($params['mime-type']);
	} else {
	$tmp = new TempFile();
	Filesystem::writeFile($tmp, $data);
	$file->setMimeType(Filesystem::getMimeType($tmp));
	}

	try {
	$file->updateDimensions(false);
	} catch (Exception $ex) {
	// Do nothing
	}

	$file->save();

	return $file;
	}

	+ public static function newFromFileData($data, array $params = array()) {
	+ $hash = self::hashFileContent($data);
	+ $file = self::newFileFromContentHash($hash, $params);
	+
	+ if ($file) {
	+ return $file;
	+ }
	+
	+ return self::buildFromFileData($data, $params);
	+ }
	+
	public function migrateToEngine(PhabricatorFileStorageEngine $engine) {
	if (!$this->getID() \|\| !$this->getStorageHandle()) {
	throw new Exception(
	"You can not migrate a file which hasn't yet been saved.");
	}

	$data = $this->loadFileData();
	$params = array(
	'name' => $this->getName(),
	);

	list($new_identifier, $new_handle) = $this->writeToEngine(
	$engine,
	$data,
	$params);

	$old_engine = $this->instantiateStorageEngine();
	$old_handle = $this->getStorageHandle();

	$this->setStorageEngine($new_identifier);
	$this->setStorageHandle($new_handle);
	$this->save();

	$old_engine->deleteFile($old_handle);

	return $this;
	}

	private function writeToEngine(
	PhabricatorFileStorageEngine $engine,
	$data,
	array $params) {

	$engine_class = get_class($engine);

	$data_handle = $engine->writeFile($data, $params);

	if (!$data_handle \|\| strlen($data_handle) > 255) {
	// This indicates an improperly implemented storage engine.
	throw new PhabricatorFileStorageConfigurationException(
	"Storage engine '{$engine_class}' executed writeFile() but did ".
	"not return a valid handle ('{$data_handle}') to the data: it ".
	"must be nonempty and no longer than 255 characters.");
	}

	$engine_identifier = $engine->getEngineIdentifier();
	if (!$engine_identifier \|\| strlen($engine_identifier) > 32) {
	throw new PhabricatorFileStorageConfigurationException(
	"Storage engine '{$engine_class}' returned an improper engine ".
	"identifier '{$engine_identifier}': it must be nonempty ".
	"and no longer than 32 characters.");
	}

	return array($engine_identifier, $data_handle);
	}


	public static function newFromFileDownload($uri, array $params) {
	$uri = new PhutilURI($uri);

	$protocol = $uri->getProtocol();
	switch ($protocol) {
	case 'http':
	case 'https':
	break;
	default:
	// Make sure we are not accessing any file:// URIs or similar.
	return null;
	}

	$timeout = 5;

	list($file_data) = id(new HTTPSFuture($uri))
	->setTimeout($timeout)
	->resolvex();

	return self::newFromFileData($file_data, $params);
	}

	public static function normalizeFileName($file_name) {
	return preg_replace('/[^a-zA-Z0-9.~_-]/', '_', $file_name);
	}

	public function delete() {
	- $engine = $this->instantiateStorageEngine();
	+ // Check to see if other files are using storage
	+ $other_file = id(new PhabricatorFile())->loadAllWhere(
	+ 'storageEngine = %s AND storageHandle = %s AND
	+ storageFormat = %s AND id != %d LIMIT 1', $this->getStorageEngine(),
	+ $this->getStorageHandle(), $this->getStorageFormat(),
	+ $this->getID());

	- $ret = parent::delete();
	+ // If this is the only file using the storage, delete storage
	+ if (count($other_file) == 0) {
	+ $engine = $this->instantiateStorageEngine();
	+ $engine->deleteFile($this->getStorageHandle());
	+ }

	- $engine->deleteFile($this->getStorageHandle());
	+ $ret = parent::delete();

	return $ret;
	}

	+ public static function hashFileContent($data) {
	+ return PhabricatorHash::digest($data);
	+ }
	+
	public function loadFileData() {

	$engine = $this->instantiateStorageEngine();
	$data = $engine->readFile($this->getStorageHandle());

	switch ($this->getStorageFormat()) {
	case self::STORAGE_FORMAT_RAW:
	$data = $data;
	break;
	default:
	throw new Exception("Unknown storage format.");
	}

	return $data;
	}

	public function getViewURI() {
	if (!$this->getPHID()) {
	throw new Exception(
	"You must save a file before you can generate a view URI.");
	}

	$name = phutil_escape_uri($this->getName());

	$path = '/file/data/'.$this->getSecretKey().'/'.$this->getPHID().'/'.$name;
	return PhabricatorEnv::getCDNURI($path);
	}

	public function getInfoURI() {
	return '/file/info/'.$this->getPHID().'/';
	}

	public function getBestURI() {
	if ($this->isViewableInBrowser()) {
	return $this->getViewURI();
	} else {
	return $this->getInfoURI();
	}
	}

	public function getDownloadURI() {
	$uri = id(new PhutilURI($this->getViewURI()))
	->setQueryParam('download', true);
	return (string) $uri;
	}

	public function getThumb60x45URI() {
	$path = '/file/xform/thumb-60x45/'.$this->getPHID().'/'
	.$this->getSecretKey().'/';
	return PhabricatorEnv::getCDNURI($path);
	}

	public function getThumb160x120URI() {
	$path = '/file/xform/thumb-160x120/'.$this->getPHID().'/'
	.$this->getSecretKey().'/';
	return PhabricatorEnv::getCDNURI($path);
	}

	public function getPreview220URI() {
	$path = '/file/xform/preview-220/'.$this->getPHID().'/'
	.$this->getSecretKey().'/';
	return PhabricatorEnv::getCDNURI($path);
	}

	public function getThumb220x165URI() {
	$path = '/file/xform/thumb-220x165/'.$this->getPHID().'/'
	.$this->getSecretKey().'/';
	return PhabricatorEnv::getCDNURI($path);
	}

	public function isViewableInBrowser() {
	return ($this->getViewableMimeType() !== null);
	}

	public function isViewableImage() {
	if (!$this->isViewableInBrowser()) {
	return false;
	}

	$mime_map = PhabricatorEnv::getEnvConfig('files.image-mime-types');
	$mime_type = $this->getMimeType();
	return idx($mime_map, $mime_type);
	}

	public function isTransformableImage() {

	// NOTE: The way the 'gd' extension works in PHP is that you can install it
	// with support for only some file types, so it might be able to handle
	// PNG but not JPEG. Try to generate thumbnails for whatever we can. Setup
	// warns you if you don't have complete support.

	$matches = null;
	$ok = preg_match(
	'@^image/(gif\|png\|jpe?g)@',
	$this->getViewableMimeType(),
	$matches);
	if (!$ok) {
	return false;
	}

	switch ($matches[1]) {
	case 'jpg';
	case 'jpeg':
	return function_exists('imagejpeg');
	break;
	case 'png':
	return function_exists('imagepng');
	break;
	case 'gif':
	return function_exists('imagegif');
	break;
	default:
	throw new Exception('Unknown type matched as image MIME type.');
	}
	}

	public static function getTransformableImageFormats() {
	$supported = array();

	if (function_exists('imagejpeg')) {
	$supported[] = 'jpg';
	}

	if (function_exists('imagepng')) {
	$supported[] = 'png';
	}

	if (function_exists('imagegif')) {
	$supported[] = 'gif';
	}

	return $supported;
	}

	protected function instantiateStorageEngine() {
	return self::buildEngine($this->getStorageEngine());
	}

	public static function buildEngine($engine_identifier) {
	$engines = self::buildAllEngines();
	foreach ($engines as $engine) {
	if ($engine->getEngineIdentifier() == $engine_identifier) {
	return $engine;
	}
	}

	throw new Exception(
	"Storage engine '{$engine_identifier}' could not be located!");
	}

	public static function buildAllEngines() {
	$engines = id(new PhutilSymbolLoader())
	->setType('class')
	->setConcreteOnly(true)
	->setAncestorClass('PhabricatorFileStorageEngine')
	->selectAndLoadSymbols();

	$results = array();
	foreach ($engines as $engine_class) {
	$results[] = newv($engine_class['name'], array());
	}

	return $results;
	}

	public function getViewableMimeType() {
	$mime_map = PhabricatorEnv::getEnvConfig('files.viewable-mime-types');

	$mime_type = $this->getMimeType();
	$mime_parts = explode(';', $mime_type);
	$mime_type = trim(reset($mime_parts));

	return idx($mime_map, $mime_type);
	}

	public function validateSecretKey($key) {
	return ($key == $this->getSecretKey());
	}

	public function save() {
	if (!$this->getSecretKey()) {
	$this->setSecretKey($this->generateSecretKey());
	}
	return parent::save();
	}

	public function generateSecretKey() {
	return Filesystem::readRandomCharacters(20);
	}

	public function updateDimensions($save = true) {
	if (!$this->isViewableImage()) {
	throw new Exception(
	"This file is not a viewable image.");
	}

	if (!function_exists("imagecreatefromstring")) {
	throw new Exception(
	"Cannot retrieve image information.");
	}

	$data = $this->loadFileData();

	$img = imagecreatefromstring($data);
	if ($img === false) {
	throw new Exception(
	"Error when decoding image.");
	}

	$this->metadata[self::METADATA_IMAGE_WIDTH] = imagesx($img);
	$this->metadata[self::METADATA_IMAGE_HEIGHT] = imagesy($img);

	if ($save) {
	$this->save();
	}

	return $this;
	}

	public static function getMetadataName($metadata) {
	switch ($metadata) {
	case self::METADATA_IMAGE_WIDTH:
	$name = pht('Width');
	break;
	case self::METADATA_IMAGE_HEIGHT:
	$name = pht('Height');
	break;
	default:
	$name = ucfirst($metadata);
	break;
	}

	return $name;
	}


	/* -( PhabricatorPolicyInterface Implementation )-------------------------- */


	public function getCapabilities() {
	return array(
	PhabricatorPolicyCapability::CAN_VIEW,
	);
	}

	public function getPolicy($capability) {
	// TODO: Implement proper per-object policies.
	return PhabricatorPolicies::POLICY_USER;
	}

	public function hasAutomaticCapability($capability, PhabricatorUser $viewer) {
	return false;
	}

	}
	diff --git a/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php b/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
	index 334d3a92f1..f794585080 100644
	--- a/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
	+++ b/src/applications/files/storage/__tests__/PhabricatorFileTestCase.php
	@@ -1,61 +1,129 @@
	<?php

	final class PhabricatorFileTestCase extends PhabricatorTestCase {

	public function getPhabricatorTestCaseConfiguration() {
	return array(
	self::PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES => true,
	);
	}

	public function testFileStorageReadWrite() {
	$engine = new PhabricatorTestStorageEngine();

	$data = Filesystem::readRandomCharacters(64);

	$params = array(
	'name' => 'test.dat',
	'storageEngines' => array(
	$engine,
	),
	);

	$file = PhabricatorFile::newFromFileData($data, $params);

	// Test that the storage engine worked, and was the target of the write. We
	// don't actually care what the data is (future changes may compress or
	// encrypt it), just that it exists in the test storage engine.
	$engine->readFile($file->getStorageHandle());

	// Now test that we get the same data back out.
	$this->assertEqual($data, $file->loadFileData());
	}

	+ public function testFileStorageUploadDifferentFiles() {
	+ $engine = new PhabricatorTestStorageEngine();
	+
	+ $data = Filesystem::readRandomCharacters(64);
	+ $other_data = Filesystem::readRandomCharacters(64);
	+
	+ $params = array(
	+ 'name' => 'test.dat',
	+ 'storageEngines' => array(
	+ $engine,
	+ ),
	+ );
	+
	+ $first_file = PhabricatorFile::newFromFileData($data, $params);
	+
	+ $second_file = PhabricatorFile::newFromFileData($other_data, $params);
	+
	+ // Test that the the second file uses different storage handle from
	+ // the first file.
	+ $first_handle = $first_file->getStorageHandle();
	+ $second_handle = $second_file->getStorageHandle();
	+
	+ $this->assertEqual(true, ($first_handle != $second_handle));
	+ }
	+
	+
	+ public function testFileStorageUploadSameFile() {
	+ $engine = new PhabricatorTestStorageEngine();
	+
	+ $data = Filesystem::readRandomCharacters(64);
	+
	+ $params = array(
	+ 'name' => 'test.dat',
	+ 'storageEngines' => array(
	+ $engine,
	+ ),
	+ );
	+
	+ $first_file = PhabricatorFile::newFromFileData($data, $params);
	+
	+ $second_file = PhabricatorFile::newFromFileData($data, $params);
	+
	+ // Test that the the second file uses the same storage handle as
	+ // the first file.
	+ $handle = $first_file->getStorageHandle();
	+ $second_handle = $second_file->getStorageHandle();
	+
	+ $this->assertEqual($handle, $second_handle);
	+ }

	public function testFileStorageDelete() {
	$engine = new PhabricatorTestStorageEngine();

	$data = Filesystem::readRandomCharacters(64);

	$params = array(
	'name' => 'test.dat',
	'storageEngines' => array(
	$engine,
	),
	);

	$file = PhabricatorFile::newFromFileData($data, $params);
	$handle = $file->getStorageHandle();
	$file->delete();

	$caught = null;
	try {
	$engine->readFile($handle);
	} catch (Exception $ex) {
	$caught = $ex;
	}

	$this->assertEqual(true, $caught instanceof Exception);
	}

	+ public function testFileStorageDeleteSharedHandle() {
	+ $engine = new PhabricatorTestStorageEngine();
	+
	+ $data = Filesystem::readRandomCharacters(64);
	+
	+ $params = array(
	+ 'name' => 'test.dat',
	+ 'storageEngines' => array(
	+ $engine,
	+ ),
	+ );
	+
	+ $first_file = PhabricatorFile::newFromFileData($data, $params);
	+ $second_file = PhabricatorFile::newFromFileData($data, $params);
	+ $first_file->delete();
	+
	+ $this->assertEqual($data, $second_file->loadFileData());
	+ }
	+
	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 15:21 (3 w, 1 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1125945
Default Alt Text: (23 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions