No OneTemporary
Actions

Size

51 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
	index 81d83f3a8b..e1192c3e7e 100644
	--- a/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
	+++ b/src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php
	@@ -1,690 +1,701 @@
	<?php

	/*
	* Copyright 2011 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	class DifferentialRevisionViewController extends DifferentialController {

	private $revisionID;

	public function willProcessRequest(array $data) {
	$this->revisionID = $data['id'];
	}

	public function processRequest() {

	$request = $this->getRequest();
	$user = $request->getUser();

	$revision = id(new DifferentialRevision())->load($this->revisionID);
	if (!$revision) {
	return new Aphront404Response();
	}

	$revision->loadRelationships();

	$diffs = $revision->loadDiffs();

	if (!$diffs) {
	throw new Exception(
	"This revision has no diffs. Something has gone quite wrong.");
	}

	$diff_vs = $request->getInt('vs');

	$target = end($diffs);
	$target_id = $request->getInt('id');
	if ($target_id) {
	if (isset($diffs[$target_id])) {
	$target = $diffs[$target_id];
	}
	}

	$diffs = mpull($diffs, null, 'getID');
	if (empty($diffs[$diff_vs])) {
	$diff_vs = null;
	}

	list($changesets, $vs_map, $rendering_references) =
	$this->loadChangesetsAndVsMap($diffs, $diff_vs, $target);

	$comments = $revision->loadComments();
	$comments = array_merge(
	$this->getImplicitComments($revision),
	$comments);

	$all_changesets = $changesets;
	$inlines = $this->loadInlineComments($comments, $all_changesets);

	$object_phids = array_merge(
	$revision->getReviewers(),
	$revision->getCCPHIDs(),
	$revision->loadCommitPHIDs(),
	array(
	$revision->getAuthorPHID(),
	$user->getPHID(),
	),
	mpull($comments, 'getAuthorPHID'));

	foreach ($comments as $comment) {
	$metadata = $comment->getMetadata();
	$added_reviewers = idx(
	$metadata,
	DifferentialComment::METADATA_ADDED_REVIEWERS);
	if ($added_reviewers) {
	foreach ($added_reviewers as $phid) {
	$object_phids[] = $phid;
	}
	}
	$added_ccs = idx(
	$metadata,
	DifferentialComment::METADATA_ADDED_CCS);
	if ($added_ccs) {
	foreach ($added_ccs as $phid) {
	$object_phids[] = $phid;
	}
	}
	}

	+ if ($target->getArcanistProjectPHID()) {
	+ $object_phids[] = $target->getArcanistProjectPHID();
	+ }
	+
	foreach ($revision->getAttached() as $type => $phids) {
	foreach ($phids as $phid => $info) {
	$object_phids[] = $phid;
	}
	}
	$object_phids = array_unique($object_phids);

	$handles = id(new PhabricatorObjectHandleData($object_phids))
	->loadHandles();

	$request_uri = $request->getRequestURI();

	$limit = 100;
	$large = $request->getStr('large');
	if (count($changesets) > $limit && !$large) {
	$count = number_format(count($changesets));
	$warning = new AphrontErrorView();
	$warning->setTitle('Very Large Diff');
	$warning->setSeverity(AphrontErrorView::SEVERITY_WARNING);
	$warning->setWidth(AphrontErrorView::WIDTH_WIDE);
	$warning->appendChild(
	"<p>This diff is very large and affects {$count} files. Use ".
	"Table of Contents to open files in a standalone view. ".
	"<strong>".
	phutil_render_tag(
	'a',
	array(
	'href' => $request_uri->alter('large', 'true'),
	),
	'Show All Files Inline').
	"</strong>");
	$warning = $warning->render();

	$visible_changesets = array();
	} else {
	$warning = null;
	$visible_changesets = $changesets;
	}

	$diff_properties = id(new DifferentialDiffProperty())->loadAllWhere(
	'diffID = %d AND name IN (%Ls)',
	$target->getID(),
	array(
	'arc:lint',
	'arc:unit',
	));
	$diff_properties = mpull($diff_properties, 'getData', 'getName');

	$revision_detail = new DifferentialRevisionDetailView();
	$revision_detail->setRevision($revision);

	$custom_renderer_class = PhabricatorEnv::getEnvConfig(
	'differential.revision-custom-detail-renderer');
	if ($custom_renderer_class) {
	PhutilSymbolLoader::loadClass($custom_renderer_class);
	$custom_renderer =
	newv($custom_renderer_class, array());
	} else {
	$custom_renderer = null;
	}

	$properties = $this->getRevisionProperties(
	$revision,
	$target,
	$handles,
	$diff_properties);
	if ($custom_renderer) {
	$properties = array_merge(
	$properties,
	$custom_renderer->generateProperties($revision, $target));
	}

	$revision_detail->setProperties($properties);

	$actions = $this->getRevisionActions($revision);
	if ($custom_renderer) {
	$actions = array_merge(
	$actions,
	$custom_renderer->generateActionLinks($revision, $target));
	}

	$whitespace = $request->getStr(
	'whitespace',
	DifferentialChangesetParser::WHITESPACE_IGNORE_ALL
	);

	$revision_detail->setActions($actions);

	$revision_detail->setUser($user);

	$comment_view = new DifferentialRevisionCommentListView();
	$comment_view->setComments($comments);
	$comment_view->setHandles($handles);
	$comment_view->setInlineComments($inlines);
	$comment_view->setChangesets($all_changesets);
	$comment_view->setUser($user);
	$comment_view->setTargetDiff($target);

	$changeset_view = new DifferentialChangesetListView();
	$changeset_view->setChangesets($visible_changesets);
	$changeset_view->setEditable(true);
	$changeset_view->setStandaloneViews(true);
	$changeset_view->setRevision($revision);
	$changeset_view->setRenderingReferences($rendering_references);
	$changeset_view->setWhitespace($whitespace);

	$diff_history = new DifferentialRevisionUpdateHistoryView();
	$diff_history->setDiffs($diffs);
	$diff_history->setSelectedVersusDiffID($diff_vs);
	$diff_history->setSelectedDiffID($target->getID());
	$diff_history->setSelectedWhitespace($whitespace);

	$toc_view = new DifferentialDiffTableOfContentsView();
	$toc_view->setChangesets($changesets);
	$toc_view->setStandaloneViewLink(empty($visible_changesets));
	$toc_view->setVsMap($vs_map);
	$toc_view->setRevisionID($revision->getID());
	$toc_view->setWhitespace($whitespace);


	$draft = id(new PhabricatorDraft())->loadOneWhere(
	'authorPHID = %s AND draftKey = %s',
	$user->getPHID(),
	'differential-comment-'.$revision->getID());
	if ($draft) {
	$draft = $draft->getDraft();
	} else {
	$draft = null;
	}

	$comment_form = new DifferentialAddCommentView();
	$comment_form->setRevision($revision);
	$comment_form->setActions($this->getRevisionCommentActions($revision));
	$comment_form->setActionURI('/differential/comment/save/');
	$comment_form->setUser($user);
	$comment_form->setDraft($draft);

	$this->updateViewTime($user->getPHID(), $revision->getPHID());

	$pane_id = celerity_generate_unique_node_id();
	Javelin::initBehavior(
	'differential-keyboard-navigation',
	array(
	'haunt' => $pane_id,
	));

	return $this->buildStandardPageResponse(
	id(new DifferentialPrimaryPaneView())
	->setLineWidthFromChangesets($changesets)
	->setID($pane_id)
	->appendChild(
	$revision_detail->render().
	$comment_view->render().
	$diff_history->render().
	$warning.
	$toc_view->render().
	$changeset_view->render().
	$comment_form->render()),
	array(
	'title' => 'D'.$revision->getID().' '.$revision->getTitle(),
	));
	}

	private function getImplicitComments(DifferentialRevision $revision) {

	$template = new DifferentialComment();
	$template->setAuthorPHID($revision->getAuthorPHID());
	$template->setRevisionID($revision->getID());
	$template->setDateCreated($revision->getDateCreated());

	$comments = array();

	if (strlen($revision->getSummary())) {
	$summary_comment = clone $template;
	$summary_comment->setContent($revision->getSummary());
	$summary_comment->setAction(DifferentialAction::ACTION_SUMMARIZE);
	$comments[] = $summary_comment;
	}

	if (strlen($revision->getTestPlan())) {
	$testplan_comment = clone $template;
	$testplan_comment->setContent($revision->getTestPlan());
	$testplan_comment->setAction(DifferentialAction::ACTION_TESTPLAN);
	$comments[] = $testplan_comment;
	}

	return $comments;
	}

	private function getRevisionProperties(
	DifferentialRevision $revision,
	DifferentialDiff $diff,
	array $handles,
	array $diff_properties) {

	$properties = array();

	$status = $revision->getStatus();
	$next_step = null;
	if ($status == DifferentialRevisionStatus::ACCEPTED) {
	switch ($diff->getSourceControlSystem()) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$next_step = 'arc amend --revision '.$revision->getID();
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$next_step = 'arc commit --revision '.$revision->getID();
	break;
	}
	if ($next_step) {
	$next_step =
	' · '.
	'Next step: <tt>'.phutil_escape_html($next_step).'</tt>';
	}
	}
	$status = DifferentialRevisionStatus::getNameForRevisionStatus($status);
	$properties['Revision Status'] = '<strong>'.$status.'</strong>'.$next_step;

	$author = $handles[$revision->getAuthorPHID()];
	$properties['Author'] = $author->renderLink();

	$properties['Reviewers'] = $this->renderHandleLinkList(
	array_select_keys(
	$handles,
	$revision->getReviewers()));

	$properties['CCs'] = $this->renderHandleLinkList(
	array_select_keys(
	$handles,
	$revision->getCCPHIDs()));

	$host = $diff->getSourceMachine();
	if ($host) {
	$properties['Host'] = phutil_escape_html($host);
	}

	$path = $diff->getSourcePath();
	if ($path) {
	$branch = $diff->getBranch() ? ' ('.$diff->getBranch().')' : '';
	$properties['Path'] = phutil_escape_html("{$path} {$branch}");
	}

	$lstar = DifferentialRevisionUpdateHistoryView::renderDiffLintStar($diff);
	$lmsg = DifferentialRevisionUpdateHistoryView::getDiffLintMessage($diff);
	$ldata = idx($diff_properties, 'arc:lint');
	$ltail = null;
	if ($ldata) {
	$ldata = igroup($ldata, 'path');
	$lint_messages = array();
	foreach ($ldata as $path => $messages) {
	$message_markup = array();
	foreach ($messages as $message) {
	$path = idx($message, 'path');
	$line = idx($message, 'line');

	$code = idx($message, 'code');
	$severity = idx($message, 'severity');

	$name = idx($message, 'name');
	$description = idx($message, 'description');

	$message_markup[] =
	'<li>'.
	'<span class="lint-severity-'.phutil_escape_html($severity).'">'.
	phutil_escape_html(ucwords($severity)).
	'</span>'.
	' '.
	'('.phutil_escape_html($code).') '.
	phutil_escape_html($name).
	' at line '.phutil_escape_html($line).
	'<p>'.phutil_escape_html($description).'</p>'.
	'</li>';
	}
	$lint_messages[] =
	'<li class="lint-file-block">'.
	'Lint for <strong>'.phutil_escape_html($path).'</strong>'.
	'<ul>'.implode("\n", $message_markup).'</ul>'.
	'</li>';
	}
	$ltail =
	'<div class="differential-lint-block">'.
	'<ul>'.
	implode("\n", $lint_messages).
	'</ul>'.
	'</div>';
	}

	$properties['Lint'] = $lstar.' '.$lmsg.$ltail;

	$ustar = DifferentialRevisionUpdateHistoryView::renderDiffUnitStar($diff);
	$umsg = DifferentialRevisionUpdateHistoryView::getDiffUnitMessage($diff);

	$postponed_count = 0;
	$udata = idx($diff_properties, 'arc:unit');
	$utail = null;
	if ($udata) {
	$unit_messages = array();
	foreach ($udata as $test) {
	$name = phutil_escape_html(idx($test, 'name'));
	$result = phutil_escape_html(idx($test, 'result'));

	if ($result != DifferentialUnitTestResult::RESULT_POSTPONED &&
	$result != DifferentialUnitTestResult::RESULT_PASS) {
	$userdata = phutil_escape_html(idx($test, 'userdata'));
	if (strlen($userdata) > 256) {
	$userdata = substr($userdata, 0, 256).'...';
	}
	$userdata = str_replace("\n", '<br />', $userdata);
	$unit_messages[] =
	'<tr>'.
	'<th>'.$name.'</th>'.
	'<th class="unit-test-result">'.
	'<div class="result-'.$result.'">'.
	strtoupper($result).
	'</div>'.
	'</th>'.
	'<td>'.$userdata.'</td>'.
	'</tr>';

	$utail =
	'<div class="differential-unit-block">'.
	'<table class="differential-unit-table">'.
	implode("\n", $unit_messages).
	'</table>'.
	'</div>';
	} else if ($result == DifferentialUnitTestResult::RESULT_POSTPONED) {
	$postponed_count++;
	}
	}
	}

	if ($postponed_count > 0 &&
	$diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) {
	$umsg = $postponed_count.' '.$umsg;
	}

	$properties['Unit'] = $ustar.' '.$umsg.$utail;

	if (PhabricatorEnv::getEnvConfig('maniphest.enabled')) {
	$tasks = $revision->getAttachedPHIDs(
	PhabricatorPHIDConstants::PHID_TYPE_TASK);
	if ($tasks) {
	$links = array();
	foreach ($tasks as $task_phid) {
	$links[] = $handles[$task_phid]->renderLink();
	}
	$properties['Maniphest Tasks'] = implode('<br />', $links);
	}
	}

	$commit_phids = $revision->getCommitPHIDs();
	if ($commit_phids) {
	$links = array();
	foreach ($commit_phids as $commit_phid) {
	$links[] = $handles[$commit_phid]->renderLink();
	}
	$properties['Commits'] = implode('<br />', $links);
	}

	+ $properties['Lines'] = number_format($diff->getLineCount());
	+ $arcanist_phid = $diff->getArcanistProjectPHID();
	+ if ($arcanist_phid) {
	+ $properties['Arcanist Project'] = phutil_escape_html(
	+ $handles[$arcanist_phid]->getName());
	+ }
	+
	$properties['Apply Patch'] =
	'<tt>arc patch D'.$revision->getID().'</tt>';
	$properties['Export Patch'] =
	'<tt>arc export --revision '.$revision->getID().'</tt>';

	return $properties;
	}

	private function getRevisionActions(DifferentialRevision $revision) {
	$viewer_phid = $this->getRequest()->getUser()->getPHID();
	$viewer_is_owner = ($revision->getAuthorPHID() == $viewer_phid);
	$viewer_is_reviewer = in_array($viewer_phid, $revision->getReviewers());
	$viewer_is_cc = in_array($viewer_phid, $revision->getCCPHIDs());
	$status = $revision->getStatus();
	$revision_id = $revision->getID();
	$revision_phid = $revision->getPHID();

	$links = array();

	if ($viewer_is_owner) {
	$links[] = array(
	'class' => 'revision-edit',
	'href' => "/differential/revision/edit/{$revision_id}/",
	'name' => 'Edit Revision',
	);
	}

	if (!$viewer_is_owner && !$viewer_is_reviewer) {
	$action = $viewer_is_cc ? 'rem' : 'add';
	$links[] = array(
	'class' => $viewer_is_cc ? 'subscribe-rem' : 'subscribe-add',
	'href' => "/differential/subscribe/{$action}/{$revision_id}/",
	'name' => $viewer_is_cc ? 'Unsubscribe' : 'Subscribe',
	'instant' => true,
	);
	} else {
	$links[] = array(
	'class' => 'subscribe-rem unavailable',
	'name' => 'Automatically Subscribed',
	);
	}

	require_celerity_resource('phabricator-object-selector-css');
	require_celerity_resource('javelin-behavior-phabricator-object-selector');

	if (PhabricatorEnv::getEnvConfig('maniphest.enabled')) {
	$links[] = array(
	'class' => 'attach-maniphest',
	'name' => 'Edit Maniphest Tasks',
	'href' => "/search/attach/{$revision_phid}/TASK/",
	'sigil' => 'workflow',
	);
	}

	$links[] = array(
	'class' => 'transcripts-metamta',
	'name' => 'MetaMTA Transcripts',
	'href' => "/mail/?phid={$revision_phid}",
	);

	$links[] = array(
	'class' => 'transcripts-herald',
	'name' => 'Herald Transcripts',
	'href' => "/herald/transcript/?phid={$revision_phid}",
	);

	return $links;
	}


	private function renderHandleLinkList(array $list) {
	if (empty($list)) {
	return '<em>None</em>';
	}
	return implode(', ', mpull($list, 'renderLink'));
	}

	private function getRevisionCommentActions(DifferentialRevision $revision) {

	$actions = array(
	DifferentialAction::ACTION_COMMENT => true,
	);

	$viewer_phid = $this->getRequest()->getUser()->getPHID();
	$viewer_is_owner = ($viewer_phid == $revision->getAuthorPHID());
	$viewer_is_reviewer = in_array($viewer_phid, $revision->getReviewers());

	if ($viewer_is_owner) {
	switch ($revision->getStatus()) {
	case DifferentialRevisionStatus::NEEDS_REVIEW:
	$actions[DifferentialAction::ACTION_ABANDON] = true;
	$actions[DifferentialAction::ACTION_RETHINK] = true;
	break;
	case DifferentialRevisionStatus::NEEDS_REVISION:
	$actions[DifferentialAction::ACTION_ABANDON] = true;
	$actions[DifferentialAction::ACTION_REQUEST] = true;
	break;
	case DifferentialRevisionStatus::ACCEPTED:
	$actions[DifferentialAction::ACTION_ABANDON] = true;
	$actions[DifferentialAction::ACTION_REQUEST] = true;
	$actions[DifferentialAction::ACTION_RETHINK] = true;
	break;
	case DifferentialRevisionStatus::COMMITTED:
	break;
	case DifferentialRevisionStatus::ABANDONED:
	$actions[DifferentialAction::ACTION_RECLAIM] = true;
	break;
	}
	} else {
	switch ($revision->getStatus()) {
	case DifferentialRevisionStatus::NEEDS_REVIEW:
	$actions[DifferentialAction::ACTION_ACCEPT] = true;
	$actions[DifferentialAction::ACTION_REJECT] = true;
	$actions[DifferentialAction::ACTION_RESIGN] = $viewer_is_reviewer;
	break;
	case DifferentialRevisionStatus::NEEDS_REVISION:
	$actions[DifferentialAction::ACTION_ACCEPT] = true;
	$actions[DifferentialAction::ACTION_RESIGN] = $viewer_is_reviewer;
	break;
	case DifferentialRevisionStatus::ACCEPTED:
	$actions[DifferentialAction::ACTION_REJECT] = true;
	break;
	case DifferentialRevisionStatus::COMMITTED:
	case DifferentialRevisionStatus::ABANDONED:
	break;
	}
	}

	$actions[DifferentialAction::ACTION_ADDREVIEWERS] = true;
	$actions[DifferentialAction::ACTION_ADDCCS] = true;

	return array_keys(array_filter($actions));
	}

	private function loadInlineComments(array $comments, array &$changesets) {

	$inline_comments = array();

	$comment_ids = array_filter(mpull($comments, 'getID'));
	if (!$comment_ids) {
	return $inline_comments;
	}

	$inline_comments = id(new DifferentialInlineComment())
	->loadAllWhere(
	'commentID in (%Ld)',
	$comment_ids);

	$load_changesets = array();
	foreach ($inline_comments as $inline) {
	$changeset_id = $inline->getChangesetID();
	if (isset($changesets[$changeset_id])) {
	continue;
	}
	$load_changesets[$changeset_id] = true;
	}

	$more_changesets = array();
	if ($load_changesets) {
	$changeset_ids = array_keys($load_changesets);
	$more_changesets += id(new DifferentialChangeset())
	->loadAllWhere(
	'id IN (%Ld)',
	$changeset_ids);
	}

	if ($more_changesets) {
	$changesets += $more_changesets;
	$changesets = msort($changesets, 'getSortKey');
	}

	return $inline_comments;
	}

	private function loadChangesetsAndVsMap(array $diffs, $diff_vs, $target) {
	$load_ids = array();
	if ($diff_vs) {
	$load_ids[] = $diff_vs;
	}
	$load_ids[] = $target->getID();

	$raw_changesets = id(new DifferentialChangeset())
	->loadAllWhere(
	'diffID IN (%Ld)',
	$load_ids);
	$changeset_groups = mgroup($raw_changesets, 'getDiffID');

	$changesets = idx($changeset_groups, $target->getID(), array());
	$changesets = mpull($changesets, null, 'getID');

	$refs = array();
	foreach ($changesets as $changeset) {
	$refs[$changeset->getID()] = $changeset->getID();
	}

	$vs_map = array();
	if ($diff_vs) {
	$vs_changesets = idx($changeset_groups, $diff_vs, array());
	$vs_changesets = mpull($vs_changesets, null, 'getFilename');
	foreach ($changesets as $key => $changeset) {
	$file = $changeset->getFilename();
	if (isset($vs_changesets[$file])) {
	$vs_map[$changeset->getID()] = $vs_changesets[$file]->getID();
	$refs[$changeset->getID()] =
	$changeset->getID().'/'.$vs_changesets[$file]->getID();
	unset($vs_changesets[$file]);
	} else {
	$refs[$changeset->getID()] = $changeset->getID();
	}
	}
	foreach ($vs_changesets as $changeset) {
	$changesets[$changeset->getID()] = $changeset;
	$vs_map[$changeset->getID()] = -1;
	$refs[$changeset->getID()] = $changeset->getID().'/-1';
	}
	}

	$changesets = msort($changesets, 'getSortKey');

	return array($changesets, $vs_map, $refs);
	}

	private function updateViewTime($user_phid, $revision_phid) {
	$view_time =
	id(new DifferentialViewTime())
	->setViewerPHID($user_phid)
	->setObjectPHID($revision_phid)
	->setViewTime(time())
	->replace();
	}
	}
	diff --git a/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php b/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php
	index 9d71845ad7..df14dfa595 100644
	--- a/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php
	+++ b/src/applications/differential/view/revisionupdatehistory/DifferentialRevisionUpdateHistoryView.php
	@@ -1,288 +1,311 @@
	<?php

	/*
	* Copyright 2011 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	final class DifferentialRevisionUpdateHistoryView extends AphrontView {

	private $diffs = array();
	private $selectedVersusDiffID;
	private $selectedDiffID;
	private $selectedWhitespace;

	public function setDiffs($diffs) {
	$this->diffs = $diffs;
	return $this;
	}

	public function setSelectedVersusDiffID($id) {
	$this->selectedVersusDiffID = $id;
	return $this;
	}

	public function setSelectedDiffID($id) {
	$this->selectedDiffID = $id;
	return $this;
	}

	public function setSelectedWhitespace($whitespace) {
	$this->selectedWhitespace = $whitespace;
	return $this;
	}

	public function render() {

	require_celerity_resource('differential-core-view-css');
	require_celerity_resource('differential-revision-history-css');

	$data = array(
	array(
	'name' => 'Base',
	'id' => null,
	'desc' => 'Base',
	'age' => null,
	'obj' => null,
	),
	);

	$seq = 0;
	foreach ($this->diffs as $diff) {
	$data[] = array(
	'name' => 'Diff '.(++$seq),
	'id' => $diff->getID(),
	'desc' => $diff->getDescription(),
	'age' => $diff->getDateCreated(),
	'obj' => $diff,
	);
	}

	$max_id = $diff->getID();

	$idx = 0;
	$rows = array();
	$disable = false;
	$radios = array();
	+ $last_base = null;
	foreach ($data as $row) {

	$name = phutil_escape_html($row['name']);
	$id = phutil_escape_html($row['id']);

	$old_class = null;
	$new_class = null;

	if ($id) {
	$new_checked = ($this->selectedDiffID == $id);
	$new = javelin_render_tag(
	'input',
	array(
	'type' => 'radio',
	'name' => 'id',
	'value' => $id,
	'checked' => $new_checked ? 'checked' : null,
	'sigil' => 'differential-new-radio',
	));
	if ($new_checked) {
	$new_class = " revhistory-new-now";
	$disable = true;
	}
	} else {
	$new = null;
	}

	if ($max_id != $id) {
	$uniq = celerity_generate_unique_node_id();
	$old_checked = ($this->selectedVersusDiffID == $id);
	$old = phutil_render_tag(
	'input',
	array(
	'type' => 'radio',
	'name' => 'vs',
	'value' => $id,
	'id' => $uniq,
	'checked' => $old_checked ? 'checked' : null,
	'disabled' => $disable ? 'disabled' : null,
	));
	$radios[] = $uniq;
	if ($old_checked) {
	$old_class = " revhistory-old-now";
	}
	} else {
	$old = null;
	}

	- $desc = phutil_escape_html($row['desc']);
	+ $desc = $row['desc'];
	+
	if ($row['age']) {
	$age = phabricator_format_timestamp($row['age']);
	} else {
	$age = null;
	}

	if (++$idx % 2) {
	$class = ' class="alt"';
	} else {
	$class = null;
	}

	if ($row['obj']) {
	$lint = self::renderDiffLintStar($row['obj']);
	$unit = self::renderDiffUnitStar($row['obj']);
	} else {
	$lint = null;
	$unit = null;
	}

	+ $base = $this->renderBaseRevision($diff);
	+ if ($last_base !== null && $base !== $last_base) {
	+ // TODO: Render some kind of notice about rebases.
	+ }
	+ $last_base = $base;
	+
	$rows[] =
	'<tr'.$class.'>'.
	'<td class="revhistory-name">'.$name.'</td>'.
	'<td class="revhistory-id">'.$id.'</td>'.
	- '<td class="revhistory-desc">'.$desc.'</td>'.
	+ '<td class="revhistory-base">'.phutil_escape_html($base).'</td>'.
	+ '<td class="revhistory-desc">'.phutil_escape_html($desc).'</td>'.
	'<td class="revhistory-age">'.$age.'</td>'.
	'<td class="revhistory-star">'.$lint.'</td>'.
	'<td class="revhistory-star">'.$unit.'</td>'.
	'<td class="revhistory-old'.$old_class.'">'.$old.'</td>'.
	'<td class="revhistory-new'.$new_class.'">'.$new.'</td>'.
	'</tr>';
	}

	- Javelin::initBehavior(
	- 'differential-diff-radios',
	- array(
	- 'radios' => $radios,
	- ));
	+ Javelin::initBehavior(
	+ 'differential-diff-radios',
	+ array(
	+ 'radios' => $radios,
	+ ));

	- $options = array(
	- 'ignore-all' => 'Ignore All',
	- 'ignore-trailing' => 'Ignore Trailing',
	- 'show-all' => 'Show All',
	- );
	+ $options = array(
	+ 'ignore-all' => 'Ignore All',
	+ 'ignore-trailing' => 'Ignore Trailing',
	+ 'show-all' => 'Show All',
	+ );

	- $select = '<select name="whitespace">';
	- foreach ($options as $value => $label) {
	- $select .= phutil_render_tag(
	- 'option',
	- array(
	- 'value' => $value,
	- 'selected' => ($value == $this->selectedWhitespace)
	- ? 'selected'
	- : null,
	- ),
	- phutil_escape_html($label));
	- }
	- $select .= '</select>';
	+ $select = '<select name="whitespace">';
	+ foreach ($options as $value => $label) {
	+ $select .= phutil_render_tag(
	+ 'option',
	+ array(
	+ 'value' => $value,
	+ 'selected' => ($value == $this->selectedWhitespace)
	+ ? 'selected'
	+ : null,
	+ ),
	+ phutil_escape_html($label));
	+ }
	+ $select .= '</select>';

	return
	'<div class="differential-revision-history differential-panel">'.
	'<h1>Revision Update History</h1>'.
	'<form>'.
	'<table class="differential-revision-history-table">'.
	'<tr>'.
	'<th>Diff</th>'.
	'<th>ID</th>'.
	+ '<th>Base</th>'.
	'<th>Description</th>'.
	'<th>Created</th>'.
	'<th>Lint</th>'.
	'<th>Unit</th>'.
	'</tr>'.
	implode("\n", $rows).
	'<tr>'.
	'<td colspan="8" class="diff-differ-submit">'.
	'<label>Whitespace Changes: '.$select.'</label>'.
	'<button>Show Diff</button>'.
	'</td>'.
	'</tr>'.
	'</table>'.
	'</form>'.
	'</div>';
	}

	const STAR_NONE = 'none';
	const STAR_OKAY = 'okay';
	const STAR_WARN = 'warn';
	const STAR_FAIL = 'fail';
	const STAR_SKIP = 'skip';

	public static function renderDiffLintStar(DifferentialDiff $diff) {
	static $map = array(
	DifferentialLintStatus::LINT_NONE => self::STAR_NONE,
	DifferentialLintStatus::LINT_OKAY => self::STAR_OKAY,
	DifferentialLintStatus::LINT_WARN => self::STAR_WARN,
	DifferentialLintStatus::LINT_FAIL => self::STAR_FAIL,
	DifferentialLintStatus::LINT_SKIP => self::STAR_SKIP,
	);

	$star = idx($map, $diff->getLintStatus(), self::STAR_FAIL);

	return self::renderDiffStar($star);
	}

	public static function renderDiffUnitStar(DifferentialDiff $diff) {
	static $map = array(
	DifferentialUnitStatus::UNIT_NONE => self::STAR_NONE,
	DifferentialUnitStatus::UNIT_OKAY => self::STAR_OKAY,
	DifferentialUnitStatus::UNIT_WARN => self::STAR_WARN,
	DifferentialUnitStatus::UNIT_FAIL => self::STAR_FAIL,
	DifferentialUnitStatus::UNIT_SKIP => self::STAR_SKIP,
	DifferentialUnitStatus::UNIT_POSTPONED => self::STAR_SKIP,
	);

	$star = idx($map, $diff->getUnitStatus(), self::STAR_FAIL);

	return self::renderDiffStar($star);
	}

	public static function getDiffLintMessage(DifferentialDiff $diff) {
	switch ($diff->getLintStatus()) {
	case DifferentialLintStatus::LINT_NONE:
	return 'No Linters Available';
	case DifferentialLintStatus::LINT_OKAY:
	return 'Lint OK';
	case DifferentialLintStatus::LINT_WARN:
	return 'Lint Warnings';
	case DifferentialLintStatus::LINT_FAIL:
	return 'Lint Errors';
	case DifferentialLintStatus::LINT_SKIP:
	return 'Lint Skipped';
	}
	return '???';
	}

	public static function getDiffUnitMessage(DifferentialDiff $diff) {
	switch ($diff->getUnitStatus()) {
	case DifferentialUnitStatus::UNIT_NONE:
	return 'No Unit Test Coverage';
	case DifferentialUnitStatus::UNIT_OKAY:
	return 'Unit Tests OK';
	case DifferentialUnitStatus::UNIT_WARN:
	return 'Unit Test Warnings';
	case DifferentialUnitStatus::UNIT_FAIL:
	return 'Unit Test Errors';
	case DifferentialUnitStatus::UNIT_SKIP:
	return 'Unit Tests Skipped';
	case DifferentialUnitStatus::UNIT_POSTPONED:
	return 'Unit Tests Postponed';
	}
	return '???';
	}

	private static function renderDiffStar($star) {
	$class = 'diff-star-'.$star;
	return
	'<span class="'.$class.'">'.
	"\xE2\x98\x85".
	'</span>';
	}

	+ private function renderBaseRevision(DifferentialDiff $diff) {
	+ switch ($diff->getSourceControlSystem()) {
	+ case 'git':
	+ return substr($diff->getSourceControlBaseRevision(), 0, 7);
	+ case 'svn':
	+ $base = $diff->getSourceControlBaseRevision();
	+ $base = explode('@', $base);
	+ $base = end($base);
	+ return $base;
	+ default:
	+ return null;
	+ }
	+ }
	}
	diff --git a/src/applications/phid/constants/PhabricatorPHIDConstants.php b/src/applications/phid/constants/PhabricatorPHIDConstants.php
	index 2b603059ff..7595bfc673 100644
	--- a/src/applications/phid/constants/PhabricatorPHIDConstants.php
	+++ b/src/applications/phid/constants/PhabricatorPHIDConstants.php
	@@ -1,37 +1,38 @@
	<?php

	/*
	* Copyright 2011 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	final class PhabricatorPHIDConstants {

	const PHID_TYPE_USER = 'USER';
	const PHID_TYPE_MLST = 'MLST';
	const PHID_TYPE_DREV = 'DREV';
	const PHID_TYPE_TASK = 'TASK';
	const PHID_TYPE_FILE = 'FILE';
	const PHID_TYPE_PROJ = 'PROJ';
	const PHID_TYPE_UNKNOWN = '????';
	const PHID_TYPE_MAGIC = '!!!!';
	const PHID_TYPE_REPO = 'REPO';
	const PHID_TYPE_CMIT = 'CMIT';
	const PHID_TYPE_OPKG = 'OPKG';
	const PHID_TYPE_PSTE = 'PSTE';
	const PHID_TYPE_STRY = 'STRY';
	const PHID_TYPE_POLL = 'POLL';
	const PHID_TYPE_WIKI = 'WIKI';
	+ const PHID_TYPE_APRJ = 'APRJ';

	}
	diff --git a/src/applications/phid/handle/data/PhabricatorObjectHandleData.php b/src/applications/phid/handle/data/PhabricatorObjectHandleData.php
	index f105c99fcd..277769d275 100644
	--- a/src/applications/phid/handle/data/PhabricatorObjectHandleData.php
	+++ b/src/applications/phid/handle/data/PhabricatorObjectHandleData.php
	@@ -1,415 +1,435 @@
	<?php

	/*
	* Copyright 2011 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	class PhabricatorObjectHandleData {

	private $phids;

	public function __construct(array $phids) {
	$this->phids = $phids;
	}

	public function loadObjects() {
	$types = array();
	foreach ($this->phids as $phid) {
	$type = $this->lookupType($phid);
	$types[$type][] = $phid;
	}

	$objects = array_fill_keys($this->phids, null);
	foreach ($types as $type => $phids) {
	switch ($type) {
	case PhabricatorPHIDConstants::PHID_TYPE_USER:
	$user_dao = newv('PhabricatorUser', array());
	$users = $user_dao->loadAllWhere(
	'phid in (%Ls)',
	$phids);
	foreach ($users as $user) {
	$objects[$user->getPHID()] = $user;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_CMIT:
	$commit_dao = newv('PhabricatorRepositoryCommit', array());
	$commits = $commit_dao->loadAllWhere(
	'phid IN (%Ls)',
	$phids);
	$commit_data = array();
	if ($commits) {
	$data_dao = newv('PhabricatorRepositoryCommitData', array());
	$commit_data = $data_dao->loadAllWhere(
	'commitID IN (%Ld)',
	mpull($commits, 'getID'));
	$commit_data = mpull($commit_data, null, 'getCommitID');
	}
	foreach ($commits as $commit) {
	$data = idx($commit_data, $commit->getID());
	if ($data) {
	$commit->attachCommitData($data);
	$objects[$commit->getPHID()] = $commit;
	} else {
	// If we couldn't load the commit data, just act as though we
	// couldn't load the object at all so we don't load half an object.
	}
	}
	break;
	}
	}

	return $objects;
	}

	public function loadHandles() {

	$types = array();
	foreach ($this->phids as $phid) {
	$type = $this->lookupType($phid);
	$types[$type][] = $phid;
	}

	$handles = array();

	$external_loaders = PhabricatorEnv::getEnvConfig('phid.external-loaders');

	foreach ($types as $type => $phids) {
	switch ($type) {
	case PhabricatorPHIDConstants::PHID_TYPE_MAGIC:
	// Black magic!
	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	switch ($phid) {
	case ManiphestTaskOwner::OWNER_UP_FOR_GRABS:
	$handle->setName('Up For Grabs');
	$handle->setFullName('upforgrabs (Up For Grabs)');
	break;
	default:
	$handle->setName('Foul Magicks');
	break;
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_USER:
	$class = 'PhabricatorUser';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$users = $object->loadAllWhere('phid IN (%Ls)', $phids);
	$users = mpull($users, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($users[$phid])) {
	$handle->setName('Unknown User');
	} else {
	$user = $users[$phid];
	$handle->setName($user->getUsername());
	$handle->setURI('/p/'.$user->getUsername().'/');
	$handle->setEmail($user->getEmail());
	$handle->setFullName(
	$user->getUsername().' ('.$user->getRealName().')');
	$handle->setAlternateID($user->getID());

	$img_phid = $user->getProfileImagePHID();
	if ($img_phid) {
	$handle->setImageURI(
	PhabricatorFileURI::getViewURIForPHID($img_phid));
	}
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_MLST:
	$class = 'PhabricatorMetaMTAMailingList';

	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$lists = $object->loadAllWhere('phid IN (%Ls)', $phids);
	$lists = mpull($lists, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($lists[$phid])) {
	$handle->setName('Unknown Mailing List');
	} else {
	$list = $lists[$phid];
	$handle->setEmail($list->getEmail());
	$handle->setName($list->getName());
	$handle->setURI($list->getURI());
	$handle->setFullName($list->getName());
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_DREV:
	$class = 'DifferentialRevision';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$revs = $object->loadAllWhere('phid in (%Ls)', $phids);
	$revs = mpull($revs, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($revs[$phid])) {
	$handle->setName('Unknown Revision');
	} else {
	$rev = $revs[$phid];
	$handle->setName($rev->getTitle());
	$handle->setURI('/D'.$rev->getID());
	$handle->setFullName('D'.$rev->getID().': '.$rev->getTitle());
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_CMIT:
	$class = 'PhabricatorRepositoryCommit';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$commits = $object->loadAllWhere('phid in (%Ls)', $phids);
	$commits = mpull($commits, null, 'getPHID');

	$repository_ids = mpull($commits, 'getRepositoryID');
	$repositories = id(new PhabricatorRepository())->loadAllWhere(
	'id in (%Ld)', array_unique($repository_ids));
	$callsigns = mpull($repositories, 'getCallsign');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($commits[$phid]) \|\|
	!isset($callsigns[$repository_ids[$phid]])) {
	$handle->setName('Unknown Commit');
	} else {
	$commit = $commits[$phid];
	$callsign = $callsigns[$repository_ids[$phid]];
	$repository = $repositories[$repository_ids[$phid]];
	$commit_identifier = $commit->getCommitIdentifier();

	// In case where the repository for the commit was deleted,
	// we don't have have info about the repository anymore.
	if ($repository) {
	$vcs = $repository->getVersionControlSystem();
	if ($vcs == PhabricatorRepositoryType::REPOSITORY_TYPE_GIT) {
	$short_identifier = substr($commit_identifier, 0, 16);
	} else {
	$short_identifier = $commit_identifier;
	}

	$handle->setName('r'.$callsign.$short_identifier);
	} else {

	$handle->setName('Commit '.'r'.$callsign.$commit_identifier);
	}

	$handle->setURI('/r'.$callsign.$commit_identifier);
	$handle->setFullName('r'.$callsign.$commit_identifier);
	$handle->setTimestamp($commit->getEpoch());
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_TASK:
	$class = 'ManiphestTask';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$tasks = $object->loadAllWhere('phid in (%Ls)', $phids);
	$tasks = mpull($tasks, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($tasks[$phid])) {
	$handle->setName('Unknown Revision');
	} else {
	$task = $tasks[$phid];
	$handle->setName($task->getTitle());
	$handle->setURI('/T'.$task->getID());
	$handle->setFullName('T'.$task->getID().': '.$task->getTitle());
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_FILE:
	$class = 'PhabricatorFile';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$files = $object->loadAllWhere('phid IN (%Ls)', $phids);
	$files = mpull($files, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($files[$phid])) {
	$handle->setName('Unknown File');
	} else {
	$file = $files[$phid];
	$handle->setName($file->getName());
	$handle->setURI($file->getViewURI());
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_PROJ:
	$class = 'PhabricatorProject';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$projects = $object->loadAllWhere('phid IN (%Ls)', $phids);
	$projects = mpull($projects, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($projects[$phid])) {
	$handle->setName('Unknown Project');
	} else {
	$project = $projects[$phid];
	$handle->setName($project->getName());
	$handle->setURI('/project/view/'.$project->getID().'/');
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_REPO:
	$class = 'PhabricatorRepository';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$repositories = $object->loadAllWhere('phid in (%Ls)', $phids);
	$repositories = mpull($repositories, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($repositories[$phid])) {
	$handle->setName('Unknown Repository');
	} else {
	$repository = $repositories[$phid];
	$handle->setName($repository->getCallsign());
	$handle->setURI('/diffusion/'.$repository->getCallsign().'/');
	}
	$handles[$phid] = $handle;
	}
	break;
	case PhabricatorPHIDConstants::PHID_TYPE_OPKG:
	$class = 'PhabricatorOwnersPackage';
	PhutilSymbolLoader::loadClass($class);
	$object = newv($class, array());

	$packages = $object->loadAllWhere('phid in (%Ls)', $phids);
	$packages = mpull($packages, null, 'getPHID');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($packages[$phid])) {
	$handle->setName('Unknown Package');
	} else {
	$package = $packages[$phid];
	$handle->setName($package->getName());
	$handle->setURI('/owners/package/'.$package->getID().'/');
	}
	$handles[$phid] = $handle;
	}
	break;
	+ case PhabricatorPHIDConstants::PHID_TYPE_APRJ:
	+ $project_dao = newv('PhabricatorRepositoryArcanistProject', array());
	+
	+ $projects = $project_dao->loadAllWhere(
	+ 'phid IN (%Ls)',
	+ $phids);
	+ $projects = mpull($projects, null, 'getPHID');
	+ foreach ($phids as $phid) {
	+ $handle = new PhabricatorObjectHandle();
	+ $handle->setPHID($phid);
	+ $handle->setType($type);
	+ if (empty($projects[$phid])) {
	+ $handle->setName('Unknown Arcanist Project');
	+ } else {
	+ $project = $projects[$phid];
	+ $handle->setName($project->getName());
	+ }
	+ $handles[$phid] = $handle;
	+ }
	+ break;
	case PhabricatorPHIDConstants::PHID_TYPE_WIKI:
	$document_dao = newv('PhrictionDocument', array());
	$content_dao = newv('PhrictionContent', array());

	$conn = $document_dao->establishConnection('r');
	$documents = queryfx_all(
	$conn,
	'SELECT * FROM %T document JOIN %T content
	ON document.contentID = content.id
	WHERE document.phid IN (%Ls)',
	$document_dao->getTableName(),
	$content_dao->getTableName(),
	$phids);
	$documents = ipull($documents, null, 'phid');

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setPHID($phid);
	$handle->setType($type);
	if (empty($documents[$phid])) {
	$handle->setName('Unknown Document');
	} else {
	$info = $documents[$phid];
	$handle->setName($info['title']);
	$handle->setURI(PhrictionDocument::getSlugURI($info['slug']));
	}
	$handles[$phid] = $handle;
	}
	break;
	default:
	$loader = null;
	if (isset($external_loaders[$type])) {
	$loader = $external_loaders[$type];
	} else if (isset($external_loaders['*'])) {
	$loader = $external_loaders['*'];
	}

	if ($loader) {
	PhutilSymbolLoader::loadClass($loader);
	$object = newv($loader, array());
	$handles += $object->loadHandles($phids);
	break;
	}

	foreach ($phids as $phid) {
	$handle = new PhabricatorObjectHandle();
	$handle->setType($type);
	$handle->setPHID($phid);
	$handle->setName('Unknown Object');
	$handle->setFullName('An Unknown Object');
	$handles[$phid] = $handle;
	}
	break;
	}
	}

	return $handles;
	}

	private function lookupType($phid) {
	$matches = null;
	if (preg_match('/^PHID-([^-]{4})-/', $phid, $matches)) {
	return $matches[1];
	}
	return PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 14:07 (3 w, 2 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1125357
Default Alt Text: (51 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions