No OneTemporary
Actions

Size

4 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php b/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
	index 0eeae59a66..7acc5824c9 100644
	--- a/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
	+++ b/src/applications/conduit/method/differential/updaterevision/ConduitAPI_differential_updaterevision_Method.php
	@@ -1,70 +1,78 @@
	<?php

	/*
	* Copyright 2011 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	class ConduitAPI_differential_updaterevision_Method extends ConduitAPIMethod {

	public function getMethodDescription() {
	return "Update a Differential revision.";
	}

	public function defineParamTypes() {
	return array(
	'id' => 'required revisionid',
	'diffid' => 'required diffid',
	'fields' => 'required dict',
	'message' => 'required string',
	);
	}

	public function defineReturnType() {
	return 'nonempty dict';
	}

	public function defineErrorTypes() {
	return array(
	'ERR_BAD_DIFF' => 'Bad diff ID.',
	'ERR_BAD_REVISION' => 'Bad revision ID.',
	+ 'ERR_WRONG_USER' => 'You are not the author of this revision.',
	+ 'ERR_COMMITTED' => 'This revision has already been committed.',
	);
	}

	protected function execute(ConduitAPIRequest $request) {
	$diff = id(new DifferentialDiff())->load($request->getValue('diffid'));
	if (!$diff) {
	throw new ConduitException('ERR_BAD_DIFF');
	}

	$revision = id(new DifferentialRevision())->load($request->getValue('id'));

	- // TODO: verify owned, non-committed, etc.
	+ if ($request->getUser()->getPHID() !== $revision->getAuthorPHID()) {
	+ throw new ConduitException('ERR_WRONG_USER');
	+ }
	+
	+ if ($revision->getStatus() == DifferentialRevisionStatus::COMMITTED) {
	+ throw new ConduitException('ERR_COMMITTED');
	+ }

	$editor = new DifferentialRevisionEditor(
	$revision,
	$revision->getAuthorPHID());
	$fields = $request->getValue('fields');
	$editor->copyFieldsFromConduit($fields);

	$editor->addDiff($diff, $request->getValue('message'));
	$editor->save();

	return array(
	'revisionid' => $revision->getID(),
	'uri' => PhabricatorEnv::getURI('/D'.$revision->getID()),
	);
	}

	}
	diff --git a/src/applications/conduit/method/differential/updaterevision/__init__.php b/src/applications/conduit/method/differential/updaterevision/__init__.php
	index 7ed1c36973..96f0fe8ce3 100644
	--- a/src/applications/conduit/method/differential/updaterevision/__init__.php
	+++ b/src/applications/conduit/method/differential/updaterevision/__init__.php
	@@ -1,19 +1,20 @@
	<?php
	/**
	* This file is automatically generated. Lint this module to rebuild it.
	* @generated
	*/



	phutil_require_module('phabricator', 'applications/conduit/method/base');
	phutil_require_module('phabricator', 'applications/conduit/protocol/exception');
	+phutil_require_module('phabricator', 'applications/differential/constants/revisionstatus');
	phutil_require_module('phabricator', 'applications/differential/editor/revision');
	phutil_require_module('phabricator', 'applications/differential/storage/diff');
	phutil_require_module('phabricator', 'applications/differential/storage/revision');
	phutil_require_module('phabricator', 'infrastructure/env');

	phutil_require_module('phutil', 'utils');


	phutil_require_source('ConduitAPI_differential_updaterevision_Method.php');

File Metadata

Mime Type: text/x-diff
Expires: Sun, Jan 19, 12:32 (3 w, 4 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1124606
Default Alt Text: (4 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions