Page MenuHomePhorge
Files F2882274

D25146.1737121866.diff
No OneTemporary
Actions

D25146.1737121866.diff
View Options

diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php
--- a/src/applications/search/controller/PhabricatorApplicationSearchController.php
+++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php
@@ -775,7 +775,7 @@
$force_nux) {
// Don't render NUX if the user has clicked away from the default page.
- if (strlen($this->getQueryKey())) {
+ if (phutil_nonempty_string($this->getQueryKey())) {
return null;
}
diff --git a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
--- a/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
+++ b/src/applications/search/engine/PhabricatorApplicationSearchEngine.php
@@ -179,7 +179,7 @@
$order = $saved->getParameter('order');
$builtin = $query->getBuiltinOrderAliasMap();
- if (strlen($order) && isset($builtin[$order])) {
+ if (phutil_nonempty_string($order) && isset($builtin[$order])) {
$query->setOrder($order);
} else {
// If the order is invalid or not available, we choose the first
diff --git a/src/view/form/control/AphrontFormTokenizerControl.php b/src/view/form/control/AphrontFormTokenizerControl.php
--- a/src/view/form/control/AphrontFormTokenizerControl.php
+++ b/src/view/form/control/AphrontFormTokenizerControl.php
@@ -68,7 +68,7 @@
$datasource->setViewer($this->getUser());
$placeholder = null;
- if (!strlen($this->placeholder)) {
+ if (!phutil_nonempty_string($this->placeholder)) {
$placeholder = $datasource->getPlaceholderText();
}
diff --git a/src/view/phui/PHUIInfoView.php b/src/view/phui/PHUIInfoView.php
--- a/src/view/phui/PHUIInfoView.php
+++ b/src/view/phui/PHUIInfoView.php
@@ -19,6 +19,12 @@
private $flush;
private $icon;
+ /**
+ * Set a title
+ *
+ * @param string|null $title
+ * @return self
+ */
public function setTitle($title) {
$this->title = $title;
return $this;
@@ -147,7 +153,7 @@
}
$title = $this->title;
- if ($title || strlen($title)) {
+ if ($title || phutil_nonempty_string($title)) {
$title = phutil_tag(
'h1',
array(

File Metadata

Mime Type
text/plain
Expires
Fri, Jan 17, 13:51 (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1120039
Default Alt Text
D25146.1737121866.diff (2 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0