Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2870999
D25336.1736831791.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
949 B
Referenced Files
None
Subscribers
None
D25336.1736831791.diff
View Options
diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -779,15 +779,15 @@
break;
case 'compare':
$uri = $this->getPathURI("/{$action}/");
- if (strlen($head)) {
+ if (phutil_nonempty_string($head)) {
$query['head'] = $head;
- } else if (strlen($raw_commit)) {
+ } else if (phutil_nonempty_string($raw_commit)) {
$query['commit'] = $raw_commit;
- } else if (strlen($raw_branch)) {
+ } else if (phutil_nonempty_string($raw_branch)) {
$query['head'] = $raw_branch;
}
- if (strlen($against)) {
+ if (phutil_nonempty_string($against)) {
$query['against'] = $against;
}
break;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Jan 14, 05:16 (6 d, 20 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1113846
Default Alt Text
D25336.1736831791.diff (949 B)
Attached To
Mode
D25336: Fix PhabricatorRepository generateURI PHP 8.1 strlen(null) errors
Attached
Detach File
Event Timeline
Log In to Comment