D25400.1736710710.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25400.1736710710.diff
View Options

	diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
	--- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php
	+++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
	@@ -478,7 +478,7 @@
	}

	$author = $this->getRawAuthorStringForDisplay();
	- if (strlen($author)) {
	+ if (phutil_nonempty_string($author)) {
	return DiffusionView::renderName($author);
	}

	@@ -493,7 +493,7 @@
	}

	$committer = $this->getRawCommitterStringForDisplay();
	- if (strlen($committer)) {
	+ if (phutil_nonempty_string($committer)) {
	return DiffusionView::renderName($committer);
	}

	diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommitData.php b/src/applications/repository/storage/PhabricatorRepositoryCommitData.php
	--- a/src/applications/repository/storage/PhabricatorRepositoryCommitData.php
	+++ b/src/applications/repository/storage/PhabricatorRepositoryCommitData.php
	@@ -131,7 +131,7 @@
	$ref = $this->getCommitRef();

	$committer = $ref->getCommitter();
	- if (strlen($committer)) {
	+ if (phutil_nonempty_string($committer)) {
	return $committer;
	}