D25771.1736628648.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25771.1736628648.diff
View Options

	diff --git a/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php b/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php
	--- a/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php
	+++ b/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php
	@@ -160,7 +160,7 @@

	switch ($key) {
	case self::PROPERTY_CONSUMER_KEY:
	- if (strlen($old)) {
	+ if (phutil_nonempty_string($old)) {
	return pht(
	'%s updated the OAuth consumer key for this provider from '.
	'"%s" to "%s".',
	@@ -175,7 +175,7 @@
	$new);
	}
	case self::PROPERTY_CONSUMER_SECRET:
	- if (strlen($old)) {
	+ if (phutil_nonempty_string($old)) {
	return pht(
	'%s updated the OAuth consumer secret for this provider.',
	$xaction->renderHandleLink($author_phid));
	diff --git a/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php b/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
	--- a/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
	+++ b/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
	@@ -144,7 +144,7 @@

	switch ($key) {
	case self::PROPERTY_NOTE:
	- if (strlen($old)) {
	+ if (phutil_nonempty_string($old)) {
	return pht(
	'%s updated the OAuth application notes for this provider.',
	$xaction->renderHandleLink($author_phid));