Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2699233
D25156.1735032946.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
963 B
Referenced Files
None
Subscribers
None
D25156.1735032946.diff
View Options
diff --git a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
--- a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
+++ b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
@@ -39,7 +39,7 @@
$query->withIsInternal(false);
$contains = $saved->getParameter('nameContains');
- if (strlen($contains)) {
+ if (phutil_nonempty_string($contains)) {
$query->withNameContains($contains);
}
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -874,7 +874,7 @@
'class' => 'phui-oi-status-icon',
);
- if (strlen($label)) {
+ if (phutil_nonempty_string($label)) {
$options['sigil'] = 'has-tooltip';
$options['meta'] = array('tip' => $label, 'size' => 300);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Dec 24, 09:35 (19 h, 28 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1027649
Default Alt Text
D25156.1735032946.diff (963 B)
Attached To
Mode
D25156: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page
Attached
Detach File
Event Timeline
Log In to Comment