Page MenuHomePhorge

D25156.1735013565.diff
No OneTemporary

D25156.1735013565.diff

diff --git a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
--- a/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
+++ b/src/applications/conduit/query/PhabricatorConduitSearchEngine.php
@@ -39,7 +39,7 @@
$query->withIsInternal(false);
$contains = $saved->getParameter('nameContains');
- if (strlen($contains)) {
+ if (phutil_nonempty_string($contains)) {
$query->withNameContains($contains);
}
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -874,7 +874,7 @@
'class' => 'phui-oi-status-icon',
);
- if (strlen($label)) {
+ if (phutil_nonempty_string($label)) {
$options['sigil'] = 'has-tooltip';
$options['meta'] = array('tip' => $label, 'size' => 300);
}

File Metadata

Mime Type
text/plain
Expires
Tue, Dec 24, 04:12 (19 h, 11 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1027649
Default Alt Text
D25156.1735013565.diff (963 B)

Event Timeline