Page MenuHomePhorge

D25200.1734992343.diff
No OneTemporary

D25200.1734992343.diff

diff --git a/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php b/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php
--- a/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php
+++ b/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php
@@ -56,7 +56,7 @@
public function getDisplayName(PhabricatorCalendarImport $import) {
$filename_key = PhabricatorCalendarImportICSFileTransaction::PARAMKEY_NAME;
$filename = $import->getParameter($filename_key);
- if (strlen($filename)) {
+ if (phutil_nonempty_string($filename)) {
return pht('ICS File "%s"', $filename);
} else {
return pht('ICS File');
diff --git a/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php b/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php
--- a/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php
+++ b/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php
@@ -53,7 +53,7 @@
$new_value = $object->getParameter(self::PARAMKEY_FILE);
foreach ($xactions as $xaction) {
$new_value = $xaction->getNewValue();
- if (!strlen($new_value)) {
+ if (!phutil_nonempty_string($new_value)) {
continue;
}

File Metadata

Mime Type
text/plain
Expires
Mon, Dec 23, 22:19 (18 h, 39 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1027116
Default Alt Text
D25200.1734992343.diff (1 KB)

Event Timeline