Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2697921
D25262.1734975643.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
985 B
Referenced Files
None
Subscribers
None
D25262.1734975643.diff
View Options
diff --git a/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php b/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php
--- a/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php
+++ b/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php
@@ -42,6 +42,11 @@
return $this;
}
+ /**
+ * Get the Coverage, expressed as a string, each letter with this meaning:
+ * N: Not Executable, C: Covered, U: Uncovered.
+ * @return string|null
+ */
public function getCoverage() {
return $this->coverage;
}
@@ -139,7 +144,7 @@
$not_applicable = '-';
$coverage = $this->getCoverage();
- if (!strlen($coverage)) {
+ if (!phutil_nonempty_string($coverage)) {
return $not_applicable;
}
@@ -157,7 +162,7 @@
$not_applicable = '-';
$coverage = $this->getCoverage();
- if (!strlen($coverage)) {
+ if (!phutil_nonempty_string($coverage)) {
return $not_applicable;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 17:40 (17 h, 47 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1026946
Default Alt Text
D25262.1734975643.diff (985 B)
Attached To
Mode
D25262: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface
Attached
Detach File
Event Timeline
Log In to Comment