Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2697914
D25184.1734974526.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25184.1734974526.diff
View Options
diff --git a/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php b/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
--- a/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
+++ b/src/applications/dashboard/install/PhabricatorDashboardObjectInstallWorkflow.php
@@ -17,16 +17,16 @@
$target_identifier = head($target_tokens);
}
- if (!strlen($target_identifier)) {
+ if (!phutil_nonempty_string($target_identifier)) {
$target_identifier = $request->getStr('target');
}
- if (!strlen($target_identifier)) {
+ if (!phutil_nonempty_string($target_identifier)) {
$target_identifier = $this->getMode();
}
$target = null;
- if (strlen($target_identifier)) {
+ if (phutil_nonempty_string($target_identifier)) {
$targets = array();
if (ctype_digit($target_identifier)) {
@@ -74,7 +74,7 @@
}
$errors = array();
- if (strlen($target_identifier)) {
+ if (phutil_nonempty_string($target_identifier)) {
if (!$target) {
$errors[] = pht('Choose a valid object.');
} else if (!$can_edit) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 17:22 (18 h, 1 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1027123
Default Alt Text
D25184.1734974526.diff (1 KB)
Attached To
Mode
D25184: Fix PHP 8.1 "strlen(null)" exceptions which block adding Dashboard to Project Menu
Attached
Detach File
Event Timeline
Log In to Comment