Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2697906
D25200.1734973725.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25200.1734973725.diff
View Options
diff --git a/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php b/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php
--- a/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php
+++ b/src/applications/calendar/import/PhabricatorCalendarICSFileImportEngine.php
@@ -56,7 +56,7 @@
public function getDisplayName(PhabricatorCalendarImport $import) {
$filename_key = PhabricatorCalendarImportICSFileTransaction::PARAMKEY_NAME;
$filename = $import->getParameter($filename_key);
- if (strlen($filename)) {
+ if (phutil_nonempty_string($filename)) {
return pht('ICS File "%s"', $filename);
} else {
return pht('ICS File');
diff --git a/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php b/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php
--- a/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php
+++ b/src/applications/calendar/xaction/PhabricatorCalendarImportICSFileTransaction.php
@@ -53,7 +53,7 @@
$new_value = $object->getParameter(self::PARAMKEY_FILE);
foreach ($xactions as $xaction) {
$new_value = $xaction->getNewValue();
- if (!strlen($new_value)) {
+ if (!phutil_nonempty_string($new_value)) {
continue;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 17:08 (18 h, 18 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1027116
Default Alt Text
D25200.1734973725.diff (1 KB)
Attached To
Mode
D25200: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS calendar file
Attached
Detach File
Event Timeline
Log In to Comment