Page MenuHomePhorge

D25412.1734929204.diff
No OneTemporary

D25412.1734929204.diff

diff --git a/src/applications/diviner/storage/DivinerLiveSymbol.php b/src/applications/diviner/storage/DivinerLiveSymbol.php
--- a/src/applications/diviner/storage/DivinerLiveSymbol.php
+++ b/src/applications/diviner/storage/DivinerLiveSymbol.php
@@ -172,7 +172,7 @@
public function getTitle() {
$title = parent::getTitle();
- if (!strlen($title)) {
+ if (!phutil_nonempty_string($title)) {
$title = $this->getName();
}
diff --git a/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php b/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
--- a/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
+++ b/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
@@ -25,7 +25,7 @@
}
public function validateTransactionValue($value) {
- if (!strlen($value)) {
+ if (!phutil_nonempty_string($value)) {
return;
}

File Metadata

Mime Type
text/plain
Expires
Mon, Dec 23, 04:46 (13 h, 46 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1026716
Default Alt Text
D25412.1734929204.diff (937 B)

Event Timeline