Page MenuHomePhorge

D25160.1734910671.diff
No OneTemporary

D25160.1734910671.diff

diff --git a/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php b/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php
--- a/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php
@@ -39,7 +39,7 @@
$viewer = $this->getViewer();
$pattern = $viewer->getUserSetting(PhabricatorEditorSetting::SETTINGKEY);
- if (!strlen($pattern)) {
+ if (!phutil_nonempty_string($pattern)) {
return null;
}

File Metadata

Mime Type
text/plain
Expires
Sun, Dec 22, 23:37 (7 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1025826
Default Alt Text
D25160.1734910671.diff (567 B)

Event Timeline