Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2696971
D25160.1734910671.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
567 B
Referenced Files
None
Subscribers
None
D25160.1734910671.diff
View Options
diff --git a/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php b/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php
--- a/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php
@@ -39,7 +39,7 @@
$viewer = $this->getViewer();
$pattern = $viewer->getUserSetting(PhabricatorEditorSetting::SETTINGKEY);
- if (!strlen($pattern)) {
+ if (!phutil_nonempty_string($pattern)) {
return null;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 23:37 (7 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1025826
Default Alt Text
D25160.1734910671.diff (567 B)
Attached To
Mode
D25160: Fix PHP 8.1 "strlen(null)" exception[s] which blocks rendering External Editor user settings page
Attached
Detach File
Event Timeline
Log In to Comment