D25246.1734852402.diff
No OneTemporary
Actions

Size

863 B

Referenced Files

None

Subscribers

None

D25246.1734852402.diff
View Options

	diff --git a/src/applications/herald/controller/HeraldTranscriptController.php b/src/applications/herald/controller/HeraldTranscriptController.php
	--- a/src/applications/herald/controller/HeraldTranscriptController.php
	+++ b/src/applications/herald/controller/HeraldTranscriptController.php
	@@ -761,6 +761,11 @@
	private function getTranscriptTransactionPHIDs(HeraldTranscript $xscript) {

	$object_xscript = $xscript->getObjectTranscript();
	+ // Work around https://we.phorge.it/T15343: For unknown reasons, calling
	+ // getObjectTranscript() on $xscript returns a "false" boolean sometimes.
	+ if ((is_bool($object_xscript) === true) && ($object_xscript) === false) {
	+ return array();
	+ }
	$xaction_phids = $object_xscript->getAppliedTransactionPHIDs();

	// If the value is "null", this is an older transcript or this adapter

File Metadata

Mime Type: text/plain
Expires: Sun, Dec 22, 07:26 (18 h, 41 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1025521
Default Alt Text: D25246.1734852402.diff (863 B)

Event Timeline