Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2695426
D25286.1734840383.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25286.1734840383.diff
View Options
diff --git a/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
@@ -37,7 +37,7 @@
$repository = $drequest->getRepository();
$path = $request->getValue('path');
- if (!strlen($path) || $path === '/') {
+ if (!phutil_nonempty_string($path) || $path === '/') {
$path = null;
}
diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@@ -22,7 +22,7 @@
// list.
$grep = $request->getStr('grep');
- if (strlen($grep)) {
+ if (phutil_nonempty_string($grep)) {
return $this->browseSearch();
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 04:06 (20 h, 43 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1025320
Default Alt Text
D25286.1734840383.diff (1 KB)
Attached To
Mode
D25286: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code
Attached
Detach File
Event Timeline
Log In to Comment