Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2695415
D25265.1734840091.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
843 B
Referenced Files
None
Subscribers
None
D25265.1734840091.diff
View Options
diff --git a/src/applications/repository/xaction/PhabricatorRepositoryDefaultBranchTransaction.php b/src/applications/repository/xaction/PhabricatorRepositoryDefaultBranchTransaction.php
--- a/src/applications/repository/xaction/PhabricatorRepositoryDefaultBranchTransaction.php
+++ b/src/applications/repository/xaction/PhabricatorRepositoryDefaultBranchTransaction.php
@@ -17,12 +17,12 @@
$old = $this->getOldValue();
$new = $this->getNewValue();
- if (!strlen($new)) {
+ if (!phutil_nonempty_string($new)) {
return pht(
'%s removed %s as the default branch.',
$this->renderAuthor(),
$this->renderOldValue());
- } else if (!strlen($old)) {
+ } else if (!phutil_nonempty_string($old)) {
return pht(
'%s set the default branch to %s.',
$this->renderAuthor(),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 04:01 (21 h, 2 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1025311
Default Alt Text
D25265.1734840091.diff (843 B)
Attached To
Mode
D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch
Attached
Detach File
Event Timeline
Log In to Comment