Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2695364
D25501.1734837320.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25501.1734837320.diff
View Options
diff --git a/src/applications/feed/query/PhabricatorFeedTransactionQuery.php b/src/applications/feed/query/PhabricatorFeedTransactionQuery.php
--- a/src/applications/feed/query/PhabricatorFeedTransactionQuery.php
+++ b/src/applications/feed/query/PhabricatorFeedTransactionQuery.php
@@ -155,6 +155,18 @@
->setAncestorClass('PhabricatorApplicationTransactionQuery')
->execute();
+ // Remove TransactionQuery classes of uninstalled apps. Increases query
+ // performance and decreases likeliness of an "Query Overheated" error if
+ // an app got uninstalled so data in it cannot be accessed anymore anyway.
+ // See https://secure.phabricator.com/T13133, https://we.phorge.it/T15642
+ foreach ($queries as $key => $query) {
+ $app = $query->getQueryApplicationClass();
+ if ($app !== null &&
+ !PhabricatorApplication::isClassInstalledForViewer($app, $viewer)) {
+ unset($queries[$key]);
+ }
+ }
+
$type_map = array();
// If we're querying for specific transaction PHIDs, we only need to
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 03:15 (19 h, 50 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1025268
Default Alt Text
D25501.1734837320.diff (1 KB)
Attached To
Mode
D25501: Feed: Do not query and display data of uninstalled applications
Attached
Detach File
Event Timeline
Log In to Comment