Page MenuHomePhorge
Files F2693843

D25367.1734770538.diff
No OneTemporary
Actions

D25367.1734770538.diff
View Options

diff --git a/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php b/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php
--- a/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php
+++ b/src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php
@@ -32,7 +32,7 @@
$panel_ref = null;
$panel_key = $request->getStr('panelKey');
- if (strlen($panel_key)) {
+ if ($panel_key !== null && strlen($panel_key)) {
$panel_ref = $ref_list->getPanelRef($panel_key);
if (!$panel_ref) {
return new Aphront404Response();
diff --git a/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php b/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
--- a/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
+++ b/src/applications/dashboard/controller/panel/PhabricatorDashboardPanelTabsController.php
@@ -41,12 +41,12 @@
$op = $request->getURIData('op');
$after = $request->getStr('after');
- if (!strlen($after)) {
+ if ($after === '') {
$after = null;
}
$target = $request->getStr('target');
- if (!strlen($target)) {
+ if ($target === '') {
$target = null;
}
diff --git a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
--- a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
+++ b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
@@ -155,6 +155,7 @@
return $this->renderNormalPanel();
} catch (Exception $ex) {
+ phlog($ex);
return $this->renderErrorPanel(
$panel->getName(),
pht(
diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php b/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
--- a/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
@@ -100,7 +100,7 @@
$panel_id = idx($tab_spec, 'panelID');
$subpanel = idx($panels, $panel_id);
- $name = idx($tab_spec, 'name');
+ $name = coalesce(idx($tab_spec, 'name'), '');
if (!strlen($name)) {
if ($subpanel) {
$name = $subpanel->getName();
diff --git a/src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php b/src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php
--- a/src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php
+++ b/src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php
@@ -27,7 +27,7 @@
PhabricatorSavedQuery $saved,
array $map) {
- if (!strlen($map['query'])) {
+ if (!phutil_nonempty_string($map['query'])) {
return;
}

File Metadata

Mime Type
text/plain
Expires
Sat, Dec 21, 08:42 (14 h, 12 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1024271
Default Alt Text
D25367.1734770538.diff (3 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0