Page MenuHomePhorge

D25364.1734770440.diff
No OneTemporary

D25364.1734770440.diff

diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
--- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
@@ -289,7 +289,7 @@
);
}
- $token_string = idx($metadata, 'token');
+ $token_string = idx($metadata, 'token', '');
if (strlen($token_string)) {
if (strlen($token_string) != 32) {
diff --git a/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
--- a/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
@@ -56,7 +56,7 @@
// show "Field:" templates for some fields even if they are empty.
$edit_mode = $request->getValue('edit');
- $is_any_edit = (bool)strlen($edit_mode);
+ $is_any_edit = (bool)$edit_mode;
$is_create = ($edit_mode == 'create');
$field_list = DifferentialCommitMessageField::newEnabledFields($viewer);

File Metadata

Mime Type
text/plain
Expires
Sat, Dec 21, 08:40 (2 h, 35 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1021161
Default Alt Text
D25364.1734770440.diff (1 KB)

Event Timeline