Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2693754
D25289.1734769710.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
818 B
Referenced Files
None
Subscribers
None
D25289.1734769710.diff
View Options
diff --git a/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php b/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php
--- a/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php
+++ b/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php
@@ -25,12 +25,12 @@
$old = $this->getOldValue();
$new = $this->getNewValue();
- if (!strlen($old)) {
+ if ($old === null) {
return pht(
'%s set the callsign for this repository to %s.',
$this->renderAuthor(),
$this->renderNewValue());
- } else if (!strlen($new)) {
+ } else if ($new === null) {
return pht(
'%s removed the callsign (%s) for this repository.',
$this->renderAuthor(),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 08:28 (2 h, 18 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1017258
Default Alt Text
D25289.1734769710.diff (818 B)
Attached To
Mode
D25289: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign
Attached
Detach File
Event Timeline
Log In to Comment