D25221.1734752330.diff
No OneTemporary
Actions

Size

834 B

Referenced Files

None

Subscribers

None

D25221.1734752330.diff
View Options

	diff --git a/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php b/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
	--- a/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
	+++ b/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
	@@ -197,7 +197,7 @@
	$alt = $options['alt'];
	}

	- if (!strlen($alt)) {
	+ if (!phutil_nonempty_string($alt)) {
	$alt = $file->getAltText();
	}

	@@ -346,10 +346,11 @@
	}

	private function parseDimension($string) {
	- $string = trim($string);
	-
	- if (preg_match('/^(?:\d*\\.)?\d+%?$/', $string)) {
	- return $string;
	+ if ($string !== null) {
	+ $string = trim($string);
	+ if (preg_match('/^(?:\d*\\.)?\d+%?$/', $string)) {
	+ return $string;
	+ }
	}

	return null;