D25141.1734741095.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25141.1734741095.diff
View Options

	diff --git a/src/applications/config/controller/PhabricatorConfigConsoleController.php b/src/applications/config/controller/PhabricatorConfigConsoleController.php
	--- a/src/applications/config/controller/PhabricatorConfigConsoleController.php
	+++ b/src/applications/config/controller/PhabricatorConfigConsoleController.php
	@@ -85,14 +85,14 @@
	$rows = array();
	foreach ($versions as $name => $info) {
	$branchpoint = $info['branchpoint'];
	- if (strlen($branchpoint)) {
	+ if (phutil_nonempty_string($branchpoint)) {
	$branchpoint = substr($branchpoint, 0, 12);
	} else {
	$branchpoint = null;
	}

	$version = $info['hash'];
	- if (strlen($version)) {
	+ if (phutil_nonempty_string($version)) {
	$version = substr($version, 0, 12);
	} else {
	$version = pht('Unknown');
	diff --git a/src/view/control/AphrontTableView.php b/src/view/control/AphrontTableView.php
	--- a/src/view/control/AphrontTableView.php
	+++ b/src/view/control/AphrontTableView.php
	@@ -135,7 +135,7 @@

	$col_classes = array();
	foreach ($this->columnClasses as $key => $class) {
	- if (strlen($class)) {
	+ if (phutil_nonempty_string($class)) {
	$col_classes[] = $class;
	} else {
	$col_classes[] = null;