D25290.1734733121.diff
No OneTemporary
Actions

Size

893 B

Referenced Files

None

Subscribers

None

D25290.1734733121.diff
View Options

	diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
	--- a/src/applications/diffusion/controller/DiffusionCommitController.php
	+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
	@@ -27,8 +27,9 @@

	// If this page is being accessed via "/source/xyz/commit/...", redirect
	// to the canonical URI.
	- $has_callsign = strlen($request->getURIData('repositoryCallsign'));
	- $has_id = strlen($request->getURIData('repositoryID'));
	+ $has_callsign =
	+ phutil_nonempty_string($request->getURIData('repositoryCallsign'));
	+ $has_id = phutil_nonempty_string($request->getURIData('repositoryID'));
	if (!$has_callsign && !$has_id) {
	$canonical_uri = $repository->getCommitURI($commit_identifier);
	return id(new AphrontRedirectResponse())

File Metadata

Mime Type: text/plain
Expires: Fri, Dec 20, 22:18 (12 h, 49 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1021208
Default Alt Text: D25290.1734733121.diff (893 B)

Event Timeline