Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2688483
D25678.1734724021.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25678.1734724021.diff
View Options
diff --git a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
--- a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
+++ b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
@@ -33,6 +33,11 @@
'%s set the point value for this task to %s.',
$this->renderAuthor(),
$this->renderNewValue());
+ } else if ($new === null && $old !== null) {
+ return pht(
+ '%s removed the point value %s for this task.',
+ $this->renderAuthor(),
+ $this->renderOldValue());
} else if ($new === null) {
return pht(
'%s removed the point value for this task.',
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
@@ -177,6 +177,12 @@
$xaction->renderHandleLink($author_phid),
$this->getFieldName(),
$new_date);
+ } else if (!$new && $old) {
+ return pht(
+ '%s removed %s which was set to %s.',
+ $xaction->renderHandleLink($author_phid),
+ $this->getFieldName(),
+ $old_date);
} else if (!$new) {
return pht(
'%s removed %s.',
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 20, 19:47 (15 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015617
Default Alt Text
D25678.1734724021.diff (1 KB)
Attached To
Mode
D25678: Expose initially set values of Maniphest custom date field and point values when removing them
Attached
Detach File
Event Timeline
Log In to Comment