D25148.1734704389.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25148.1734704389.diff
View Options

	diff --git a/src/applications/config/controller/PhabricatorConfigConsoleController.php b/src/applications/config/controller/PhabricatorConfigConsoleController.php
	--- a/src/applications/config/controller/PhabricatorConfigConsoleController.php
	+++ b/src/applications/config/controller/PhabricatorConfigConsoleController.php
	@@ -189,8 +189,18 @@
	foreach ($specs as $lib) {
	$remote_future = $remote_futures[$lib];

	- list($err, $stdout) = $remote_future->resolve();
	+ list($err, $stdout, $stderr) = $remote_future->resolve();
	if ($err) {
	+
	+ // Very probably this is a "detected dubious ownership"
	+ // Better to report it, than just ignoring it.
	+ // https://we.phorge.it/T15282
	+ phlog(sprintf(
	+ 'Cannot identify git remotes. Command: %s Exit: %d Error: %s',
	+ $remote_future->getCommand(),
	+ $err,
	+ $stderr));
	+
	// If this fails for whatever reason, just move on.
	continue;
	}
	@@ -258,10 +268,20 @@

	$results = array();
	foreach ($log_futures as $lib => $future) {
	- list($err, $stdout) = $future->resolve();
	+ list($err, $stdout, $stderr) = $future->resolve();
	if (!$err) {
	list($hash, $epoch) = explode(' ', $stdout);
	} else {
	+
	+ // Very probably this is a "detected dubious ownership"
	+ // Better to report it, than just ignoring it.
	+ // https://we.phorge.it/T15282
	+ phlog(sprintf(
	+ 'Cannot open git log. Command: %s Exit: %d Error: %s',
	+ $future->getCommand(),
	+ $err,
	+ $stderr));
	+
	$hash = null;
	$epoch = null;
	}