Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2683395
D25409.1734684335.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
784 B
Referenced Files
None
Subscribers
None
D25409.1734684335.diff
View Options
diff --git a/src/parser/ArcanistBundle.php b/src/parser/ArcanistBundle.php
--- a/src/parser/ArcanistBundle.php
+++ b/src/parser/ArcanistBundle.php
@@ -762,7 +762,7 @@
$old_data = $this->getBlob($old_phid, $name);
}
- $old_length = strlen($old_data);
+ $old_length = phutil_nonempty_string($old_data) ? strlen($old_data) : 0;
// Here, and below, the binary will be emitted with base85 encoding. This
// encoding encodes each 4 bytes of input in 5 bytes of output, so we may
@@ -795,7 +795,7 @@
$new_data = $this->getBlob($new_phid, $name);
}
- $new_length = strlen($new_data);
+ $new_length = phutil_nonempty_string($new_data) ? strlen($new_data) : 0;
$this->reserveBytes($new_length * 5 / 4);
if ($new_data === null) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 20, 08:45 (20 h, 20 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1016640
Default Alt Text
D25409.1734684335.diff (784 B)
Attached To
Mode
D25409: Fix PHP 8.1 arc patch strlen(null) binary file error
Attached
Detach File
Event Timeline
Log In to Comment