Page MenuHomePhorge
Files F2682322

D25312.1734653867.diff
No OneTemporary
Actions

D25312.1734653867.diff
View Options

diff --git a/src/applications/notification/view/PhabricatorNotificationStatusView.php b/src/applications/notification/view/PhabricatorNotificationStatusView.php
--- a/src/applications/notification/view/PhabricatorNotificationStatusView.php
+++ b/src/applications/notification/view/PhabricatorNotificationStatusView.php
@@ -40,34 +40,41 @@
protected function getTagContent() {
$have = PhabricatorEnv::getEnvConfig('notification.servers');
if ($have) {
- $icon = id(new PHUIIconView())
- ->setIcon('fa-circle-o yellow');
- $text = pht('Connecting...');
- return phutil_tag(
- 'span',
- array(
- 'class' => 'connection-status-text '.
- 'aphlict-connection-status-connecting',
- ),
- array(
- $icon,
- $text,
- ));
+ return $this->buildMessageView(
+ 'aphlict-connection-status-connecting',
+ 'fa-circle-o yellow',
+ pht('Connecting...'));
} else {
- $text = pht('Notification server not enabled');
- $icon = id(new PHUIIconView())
- ->setIcon('fa-circle-o grey');
- return phutil_tag(
- 'span',
- array(
- 'class' => 'connection-status-text '.
- 'aphlict-connection-status-notenabled',
- ),
- array(
- $icon,
- $text,
- ));
+ return $this->buildMessageView(
+ 'aphlict-connection-status-notenabled',
+ 'fa-circle-o grey',
+ pht('Notification server not enabled'));
}
}
+ /**
+ * Create an icon and a message.
+ *
+ * @param string $class_name Raw CSS class name(s) space separated
+ * @param string $icon_name Icon name
+ * @param string $text Text to be shown
+ * @return array
+ */
+ private function buildMessageView($class_name, $icon_name, $text) {
+ $icon = id(new PHUIIconView())
+ ->setIcon($icon_name);
+
+ $message = phutil_tag(
+ 'span',
+ array(
+ 'class' => 'connection-status-text '.$class_name,
+ ),
+ $text);
+
+ return array(
+ $icon,
+ $message,
+ );
+ }
+
}

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 00:17 (21 h, 8 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1016267
Default Alt Text
D25312.1734653867.diff (2 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0