Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2682317
D25711.1734653773.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
2 KB
Referenced Files
None
Subscribers
None
D25711.1734653773.diff
View Options
diff --git a/src/applications/fact/extract/PhabricatorFactUpdateIterator.php b/src/applications/fact/extract/PhabricatorFactUpdateIterator.php
--- a/src/applications/fact/extract/PhabricatorFactUpdateIterator.php
+++ b/src/applications/fact/extract/PhabricatorFactUpdateIterator.php
@@ -33,6 +33,7 @@
}
}
+ #[\ReturnTypeWillChange]
public function key() {
return $this->getCursorFromObject($this->current());
}
diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php b/src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php
--- a/src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php
+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php
@@ -18,6 +18,7 @@
$this->cursor = $this->min;
}
+ #[\ReturnTypeWillChange]
public function key() {
return $this->current()->getID();
}
diff --git a/src/infrastructure/storage/lisk/LiskMigrationIterator.php b/src/infrastructure/storage/lisk/LiskMigrationIterator.php
--- a/src/infrastructure/storage/lisk/LiskMigrationIterator.php
+++ b/src/infrastructure/storage/lisk/LiskMigrationIterator.php
@@ -26,6 +26,7 @@
$this->cursor = 0;
}
+ #[\ReturnTypeWillChange]
public function key() {
return $this->current()->getID();
}
diff --git a/src/infrastructure/storage/lisk/LiskRawMigrationIterator.php b/src/infrastructure/storage/lisk/LiskRawMigrationIterator.php
--- a/src/infrastructure/storage/lisk/LiskRawMigrationIterator.php
+++ b/src/infrastructure/storage/lisk/LiskRawMigrationIterator.php
@@ -16,6 +16,7 @@
$this->cursor = 0;
}
+ #[\ReturnTypeWillChange]
public function key() {
return idx($this->current(), $this->column);
}
diff --git a/src/infrastructure/storage/lisk/PhabricatorQueryIterator.php b/src/infrastructure/storage/lisk/PhabricatorQueryIterator.php
--- a/src/infrastructure/storage/lisk/PhabricatorQueryIterator.php
+++ b/src/infrastructure/storage/lisk/PhabricatorQueryIterator.php
@@ -18,6 +18,7 @@
$this->pager = $pager;
}
+ #[\ReturnTypeWillChange]
public function key() {
return $this->current()->getID();
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 20, 00:16 (8 h, 20 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015169
Default Alt Text
D25711.1734653773.diff (2 KB)
Attached To
Mode
D25711: Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()"
Attached
Detach File
Event Timeline
Log In to Comment