Page MenuHomePhorge

D25162.1734649840.diff
No OneTemporary

D25162.1734649840.diff

diff --git a/src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php b/src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php
@@ -43,11 +43,27 @@
return $this->icon;
}
+ /**
+ * Set the text of the tag
+ *
+ * This is usually the 'name' key of your subtype map.
+ * Sometime this is an uppercase text like 'BUG' for a 'bug' subtype name.
+ *
+ * @param string|null $text
+ * @return self
+ */
public function setTagText($text) {
$this->tagText = $text;
return $this;
}
+ /**
+ * Get the text of the tag
+ *
+ * @see PhabricatorEditEngineSubtype::setTagText()
+ *
+ * @return string|null
+ */
public function getTagText() {
return $this->tagText;
}
@@ -89,7 +105,7 @@
}
public function hasTagView() {
- return (bool)strlen($this->getTagText());
+ return phutil_nonempty_string($this->getTagText());
}
public function newTagView() {

File Metadata

Mime Type
text/plain
Expires
Thu, Dec 19, 23:10 (20 h, 8 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015599
Default Alt Text
D25162.1734649840.diff (1 KB)

Event Timeline