Page MenuHomePhorge

D25691.1734647829.diff
No OneTemporary

D25691.1734647829.diff

diff --git a/src/repository/api/ArcanistSubversionAPI.php b/src/repository/api/ArcanistSubversionAPI.php
--- a/src/repository/api/ArcanistSubversionAPI.php
+++ b/src/repository/api/ArcanistSubversionAPI.php
@@ -40,6 +40,16 @@
$argv[0] = 'svn '.$argv[0];
$future = newv('ExecFuture', $argv);
+
+ // For historical reasons we run Subversion commands keeping env.
+ // But, let's keep English, to have a reliable parser.
+ // https://github.com/apache/subversion/blob/trunk/notes/l10n-problems
+ // https://www.gnu.org/software/gettext/manual/gettext.html
+ // https://svnbook.red-bean.com/en/1.7/svn.advanced.l10n.html
+ // https://superuser.com/a/1779369/390314
+ $future->updateEnv('LC_ALL', 'C'); // designed for scripts, override LC_*
+ $future->updateEnv('LANG', 'C'); // deactivate LANGUAGE, defuse LC defaults
+
$future->setCWD($this->getPath());
return $future;
}

File Metadata

Mime Type
text/plain
Expires
Thu, Dec 19, 22:37 (18 h, 31 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015723
Default Alt Text
D25691.1734647829.diff (920 B)

Event Timeline