D25487.1734639348.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25487.1734639348.diff
View Options

	diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
	--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
	+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
	@@ -40,7 +40,7 @@
	// TODO: Clean this up.

	$result = array();
	- if (!is_array($value)) {
	+ if (!is_array($value) && phutil_nonempty_string($value)) {
	$value = json_decode($value, true);
	if (is_array($value)) {
	$result = array_values($value);
	diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
	--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
	+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
	@@ -73,7 +73,7 @@
	}

	public function renderPropertyViewValue(array $handles) {
	- if (!strlen($this->getFieldValue())) {
	+ if (!phutil_nonempty_string($this->getFieldValue())) {
	return null;
	}
	return idx($this->getOptions(), $this->getFieldValue());