Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2680956
D25765.1734631446.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
641 B
Referenced Files
None
Subscribers
None
D25765.1734631446.diff
View Options
diff --git a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
--- a/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
+++ b/src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
@@ -82,7 +82,7 @@
foreach ($xactions as $xaction) {
$new = $xaction->getNewValue();
- if (strlen($new) && !is_numeric($new)) {
+ if (phutil_nonempty_string($new) && !is_numeric($new)) {
$errors[] = $this->newInvalidError(
pht('Points value must be numeric or empty.'));
continue;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Dec 19, 18:04 (20 h, 54 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015288
Default Alt Text
D25765.1734631446.diff (641 B)
Attached To
Mode
D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction
Attached
Detach File
Event Timeline
Log In to Comment