Page MenuHomePhorge
Files F2680834

D25093.1734627977.diff
No OneTemporary
Actions

D25093.1734627977.diff
View Options

diff --git a/src/applications/project/controller/PhabricatorProjectColumnEditController.php b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnEditController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
@@ -49,6 +49,9 @@
$v_limit = $column->getPointLimit();
$v_name = $column->getName();
+ $proxy = $column->getProxy();
+ $is_column = !$proxy;
+
$validation_exception = null;
$view_uri = $project->getWorkboardURI();
@@ -78,34 +81,43 @@
$type_name = PhabricatorProjectColumnNameTransaction::TRANSACTIONTYPE;
$type_limit = PhabricatorProjectColumnLimitTransaction::TRANSACTIONTYPE;
- if (!$column->getProxy()) {
+ if ($is_column) {
$xactions[] = id(new PhabricatorProjectColumnTransaction())
->setTransactionType($type_name)
->setNewValue($v_name);
}
+ // Column Points
$xactions[] = id(new PhabricatorProjectColumnTransaction())
->setTransactionType($type_limit)
->setNewValue($v_limit);
+ $saved_everything = false;
+
try {
$editor = id(new PhabricatorProjectColumnTransactionEditor())
->setActor($viewer)
->setContinueOnNoEffect(true)
->setContentSourceFromRequest($request)
->applyTransactions($column, $xactions);
- return id(new AphrontRedirectResponse())->setURI($view_uri);
+ $saved_everything = true;
} catch (PhabricatorApplicationTransactionValidationException $ex) {
$e_name = $ex->getShortMessage($type_name);
$e_limit = $ex->getShortMessage($type_limit);
$validation_exception = $ex;
}
+
+ if ($saved_everything) {
+ return id(new AphrontRedirectResponse())->setURI($view_uri);
+ }
+
}
$form = id(new AphrontFormView())
->setUser($request->getUser());
- if (!$column->getProxy()) {
+ if ($is_column) {
+ // Project Column name field
$form->appendChild(
id(new AphrontFormTextControl())
->setValue($v_name)

File Metadata

Mime Type
text/plain
Expires
Thu, Dec 19, 17:06 (18 h, 8 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015187
Default Alt Text
D25093.1734627977.diff (2 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0