Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2680741
D25423.1734620552.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
750 B
Referenced Files
None
Subscribers
None
D25423.1734620552.diff
View Options
diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
--- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
@@ -36,7 +36,7 @@
$author = $ref->getAuthor();
$committer = $ref->getCommitter();
- $has_committer = (bool)strlen($committer);
+ $has_committer = phutil_nonempty_string($committer);
$identity_engine = id(new DiffusionRepositoryIdentityEngine())
->setViewer($viewer)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Dec 19, 15:02 (20 h, 42 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1015114
Default Alt Text
D25423.1734620552.diff (750 B)
Attached To
Mode
D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser
Attached
Detach File
Event Timeline
Log In to Comment