D25373.1734613885.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25373.1734613885.diff
View Options

	diff --git a/src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php b/src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php
	--- a/src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php
	+++ b/src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php
	@@ -104,7 +104,7 @@
	->setSignatureMethod($this->getSignatureMethod());

	$consumer_key = $this->getConsumerKey();
	- if (strlen($consumer_key)) {
	+ if (phutil_nonempty_string($consumer_key)) {
	$future->setConsumerKey($consumer_key);
	} else {
	throw new Exception(
	@@ -118,11 +118,11 @@
	$future->setConsumerSecret($consumer_secret);
	}

	- if (strlen($this->getToken())) {
	+ if (phutil_nonempty_string($this->getToken())) {
	$future->setToken($this->getToken());
	}

	- if (strlen($this->getTokenSecret())) {
	+ if (phutil_nonempty_string($this->getTokenSecret())) {
	$future->setTokenSecret($this->getTokenSecret());
	}

	@@ -137,7 +137,7 @@
	$request_token_uri = $this->getRequestTokenURI();

	$future = $this->newOAuth1Future($request_token_uri);
	- if (strlen($this->getCallbackURI())) {
	+ if (phutil_nonempty_string($this->getCallbackURI())) {
	$future->setCallbackURI($this->getCallbackURI());
	}