D25578.1734612414.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D25578.1734612414.diff
View Options

	diff --git a/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php b/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
	--- a/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
	+++ b/src/applications/auth/provider/PhabricatorOAuth2AuthProvider.php
	@@ -137,7 +137,7 @@

	switch ($key) {
	case self::PROPERTY_APP_ID:
	- if (strlen($old)) {
	+ if (phutil_nonempty_string($old)) {
	return pht(
	'%s updated the OAuth application ID for this provider from '.
	'"%s" to "%s".',
	@@ -152,7 +152,7 @@
	$new);
	}
	case self::PROPERTY_APP_SECRET:
	- if (strlen($old)) {
	+ if (phutil_nonempty_string($old)) {
	return pht(
	'%s updated the OAuth application secret for this provider.',
	$xaction->renderHandleLink($author_phid));
	@@ -162,7 +162,7 @@
	$xaction->renderHandleLink($author_phid));
	}
	case self::PROPERTY_NOTE:
	- if (strlen($old)) {
	+ if (phutil_nonempty_string($old)) {
	return pht(
	'%s updated the OAuth application notes for this provider.',
	$xaction->renderHandleLink($author_phid));