Page MenuHomePhorge
Files F2657225

D25124.1732691937.diff
No OneTemporary
Actions

D25124.1732691937.diff
View Options

diff --git a/src/applications/diviner/query/DivinerBookQuery.php b/src/applications/diviner/query/DivinerBookQuery.php
--- a/src/applications/diviner/query/DivinerBookQuery.php
+++ b/src/applications/diviner/query/DivinerBookQuery.php
@@ -133,7 +133,7 @@
$this->phids);
}
- if (strlen($this->nameLike)) {
+ if (phutil_nonempty_string($this->nameLike)) {
$where[] = qsprintf(
$conn,
'name LIKE %~',
@@ -147,7 +147,7 @@
$this->names);
}
- if (strlen($this->namePrefix)) {
+ if (phutil_nonempty_string($this->namePrefix)) {
$where[] = qsprintf(
$conn,
'name LIKE %>',
diff --git a/src/applications/diviner/storage/DivinerLiveSymbol.php b/src/applications/diviner/storage/DivinerLiveSymbol.php
--- a/src/applications/diviner/storage/DivinerLiveSymbol.php
+++ b/src/applications/diviner/storage/DivinerLiveSymbol.php
@@ -182,7 +182,7 @@
public function setTitle($value) {
$this->writeField('title', $value);
- if (strlen($value)) {
+ if (phutil_nonempty_string($value)) {
$slug = DivinerAtomRef::normalizeTitleString($value);
$hash = PhabricatorHash::digestForIndex($slug);
$this->titleSlugHash = $hash;
diff --git a/src/applications/diviner/workflow/DivinerGenerateWorkflow.php b/src/applications/diviner/workflow/DivinerGenerateWorkflow.php
--- a/src/applications/diviner/workflow/DivinerGenerateWorkflow.php
+++ b/src/applications/diviner/workflow/DivinerGenerateWorkflow.php
@@ -194,7 +194,7 @@
$identifier = $args->getArg('repository');
$repository = null;
- if (strlen($identifier)) {
+ if (phutil_nonempty_string($identifier)) {
$repository = id(new PhabricatorRepositoryQuery())
->setViewer(PhabricatorUser::getOmnipotentUser())
->withIdentifiers(array($identifier))

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 27, 07:18 (20 h, 55 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
998272
Default Alt Text
D25124.1732691937.diff (1 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0