Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2630739
D25284.1732063509.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
893 B
Referenced Files
None
Subscribers
None
D25284.1732063509.diff
View Options
diff --git a/src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php b/src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php
--- a/src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php
+++ b/src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php
@@ -17,12 +17,12 @@
$old = $this->getOldValue();
$new = $this->getNewValue();
- if (strlen($old) && !strlen($new)) {
+ if ($old !== null && $new === null) {
return pht(
'%s removed the %s encoding configured for this repository.',
$this->renderAuthor(),
$this->renderOldValue());
- } else if (strlen($new) && !strlen($old)) {
+ } else if ($new !== null && $old === null) {
return pht(
'%s set the encoding for this repository to %s.',
$this->renderAuthor(),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Nov 20, 00:45 (20 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
979591
Default Alt Text
D25284.1732063509.diff (893 B)
Attached To
Mode
D25284: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding
Attached
Detach File
Event Timeline
Log In to Comment