Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2629718
D25462.1732045042.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25462.1732045042.diff
View Options
diff --git a/src/applications/files/transform/PhabricatorFileImageTransform.php b/src/applications/files/transform/PhabricatorFileImageTransform.php
--- a/src/applications/files/transform/PhabricatorFileImageTransform.php
+++ b/src/applications/files/transform/PhabricatorFileImageTransform.php
@@ -137,8 +137,12 @@
protected function newFileFromData($data) {
if ($this->file) {
$name = $this->file->getName();
+ $inherit_properties = array(
+ 'viewPolicy' => $this->file->getViewPolicy(),
+ );
} else {
$name = 'default.png';
+ $inherit_properties = array();
}
$defaults = array(
@@ -146,7 +150,7 @@
'name' => $this->getTransformKey().'-'.$name,
);
- $properties = $this->getFileProperties() + $defaults;
+ $properties = $this->getFileProperties() + $inherit_properties + $defaults;
return PhabricatorFile::newFromFileData($data, $properties);
}
diff --git a/src/applications/files/transform/PhabricatorFileThumbnailTransform.php b/src/applications/files/transform/PhabricatorFileThumbnailTransform.php
--- a/src/applications/files/transform/PhabricatorFileThumbnailTransform.php
+++ b/src/applications/files/transform/PhabricatorFileThumbnailTransform.php
@@ -58,7 +58,7 @@
public function generateTransforms() {
return array(
id(new PhabricatorFileThumbnailTransform())
- ->setName(pht("Profile (400px \xC3\x97 400px)"))
+ ->setName(pht("Profile (400px \xC3\x97 400px) (Image will be Public)"))
->setKey(self::TRANSFORM_PROFILE)
->setDimensions(400, 400)
->setScaleUp(true),
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 19, 19:37 (20 h, 31 s)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
978820
Default Alt Text
D25462.1732045042.diff (1 KB)
Attached To
Mode
D25462: Fix view policy inheritance on image transforms
Attached
Detach File
Event Timeline
Log In to Comment