Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2629612
D25588.1732044203.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25588.1732044203.diff
View Options
diff --git a/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php b/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php
--- a/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php
+++ b/src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php
@@ -51,7 +51,7 @@
list($engine, $queries) = $this->newQueries($args);
$format_key = $args->getArg('format');
- if (!strlen($format_key)) {
+ if (!phutil_nonempty_string($format_key)) {
throw new PhutilArgumentUsageException(
pht(
'Specify an export format with "--format".'));
@@ -77,7 +77,7 @@
$is_overwrite = $args->getArg('overwrite');
$output_path = $args->getArg('output');
- if (!strlen($output_path)) {
+ if (!phutil_nonempty_string($output_path)) {
throw new PhutilArgumentUsageException(
pht(
'Use "--output <path>" to specify an output file, or "--output -" '.
@@ -164,7 +164,7 @@
->execute();
$class = $args->getArg('class');
- if (strlen($class)) {
+ if (phutil_nonempty_string($class)) {
$class_list = array();
foreach ($engine_classes as $class_name => $engine_object) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 19, 19:23 (21 h, 49 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
978115
Default Alt Text
D25588.1732044203.diff (1 KB)
Attached To
Mode
D25588: Fix PHP 8.1 "strlen(null)" exception for "/bin/bulk export --query --format" without parameter
Attached
Detach File
Event Timeline
Log In to Comment