Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2629194
D25586.1732040743.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
901 B
Referenced Files
None
Subscribers
None
D25586.1732040743.diff
View Options
diff --git a/src/applications/herald/management/HeraldTestManagementWorkflow.php b/src/applications/herald/management/HeraldTestManagementWorkflow.php
--- a/src/applications/herald/management/HeraldTestManagementWorkflow.php
+++ b/src/applications/herald/management/HeraldTestManagementWorkflow.php
@@ -30,7 +30,7 @@
$viewer = $this->getViewer();
$object_name = $args->getArg('object');
- if (!strlen($object_name)) {
+ if (!phutil_nonempty_string($object_name)) {
throw new PhutilArgumentUsageException(
pht('Specify an object to test rules for with "--object".'));
}
@@ -69,7 +69,7 @@
$content_type = $args->getArg('type');
- if (!strlen($content_type)) {
+ if (!phutil_nonempty_string($content_type)) {
throw new PhutilArgumentUsageException(
pht(
'Specify a content type to run rules for. For this object, valid '.
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 19, 18:25 (22 h, 2 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
978422
Default Alt Text
D25586.1732040743.diff (901 B)
Attached To
Mode
D25586: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter
Attached
Detach File
Event Timeline
Log In to Comment