Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2628373
D25190.1732023780.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25190.1732023780.diff
View Options
diff --git a/src/infrastructure/contentsource/PhabricatorContentSource.php b/src/infrastructure/contentsource/PhabricatorContentSource.php
--- a/src/infrastructure/contentsource/PhabricatorContentSource.php
+++ b/src/infrastructure/contentsource/PhabricatorContentSource.php
@@ -81,6 +81,13 @@
));
}
+ /**
+ * Get the internal source name
+ *
+ * This is usually coming from a SOURCECONST constant.
+ *
+ * @return string|null
+ */
final public function getSource() {
return $this->source;
}
diff --git a/src/infrastructure/contentsource/PhabricatorUnknownContentSource.php b/src/infrastructure/contentsource/PhabricatorUnknownContentSource.php
--- a/src/infrastructure/contentsource/PhabricatorUnknownContentSource.php
+++ b/src/infrastructure/contentsource/PhabricatorUnknownContentSource.php
@@ -7,7 +7,7 @@
public function getSourceName() {
$source = $this->getSource();
- if (strlen($source)) {
+ if ($source) {
return pht('Unknown ("%s")', $source);
} else {
return pht('Unknown');
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 19, 13:43 (21 h, 14 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
977776
Default Alt Text
D25190.1732023780.diff (1 KB)
Attached To
Mode
D25190: Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules
Attached
Detach File
Event Timeline
Log In to Comment