Page MenuHomePhorge

D25295.1732022933.diff
No OneTemporary

D25295.1732022933.diff

diff --git a/src/applications/repository/xaction/PhabricatorRepositoryMaintenanceTransaction.php b/src/applications/repository/xaction/PhabricatorRepositoryMaintenanceTransaction.php
--- a/src/applications/repository/xaction/PhabricatorRepositoryMaintenanceTransaction.php
+++ b/src/applications/repository/xaction/PhabricatorRepositoryMaintenanceTransaction.php
@@ -25,11 +25,14 @@
$old = $this->getOldValue();
$new = $this->getNewValue();
- if (strlen($old) && !strlen($new)) {
+ $old_nonempty = phutil_nonempty_string($old);
+ $new_nonempty = phutil_nonempty_string($new);
+
+ if ($old_nonempty && !$new_nonempty) {
return pht(
'%s took this repository out of maintenance mode.',
$this->renderAuthor());
- } else if (!strlen($old) && strlen($new)) {
+ } else if (!$old_nonempty && $new_nonempty) {
return pht(
'%s put this repository into maintenance mode.',
$this->renderAuthor());

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 19, 13:28 (20 h, 6 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
977600
Default Alt Text
D25295.1732022933.diff (967 B)

Event Timeline