Page MenuHomePhorge

D25615.1732016119.diff
No OneTemporary

D25615.1732016119.diff

diff --git a/src/applications/config/option/PhabricatorUIConfigOptions.php b/src/applications/config/option/PhabricatorUIConfigOptions.php
--- a/src/applications/config/option/PhabricatorUIConfigOptions.php
+++ b/src/applications/config/option/PhabricatorUIConfigOptions.php
@@ -29,7 +29,7 @@
'dark' => pht('Dark'),
);
- $example = <<<EOJSON
+ $footerexample = <<<EOJSON
[
{
"name" : "Copyright 2199 Examplecorp"
@@ -43,6 +43,16 @@
"href" : "http://www.example.org/terms/"
}
]
+EOJSON;
+
+ $faviconexample = <<<EOJSON
+[
+ {
+ "source": "PHID-FILE-jm4lho3u6rwr6glhy2wd",
+ "width": 500,
+ "height": 500
+ }
+]
EOJSON;
$logo_type = 'custom:PhabricatorCustomLogoConfigType';
@@ -66,9 +76,19 @@
"By default, the header displays //%s//.\n\n",
PlatformSymbols::getPlatformServerName())),
$this->newOption('ui.favicons', 'wild', array())
- ->setSummary(pht('Customize favicons.'))
- ->setDescription(pht('Customize favicons.'))
- ->setLocked(true),
+ ->setSummary(pht('Allows you to customize favicons.'))
+ ->setDescription(
+ pht(
+ "Allows you to customize favicons. \n\n".
+ " - Files must be square images, and should be PNG files.\n".
+ " - Upload the file and grab the PHID for your image with `file.search` API.\n\n".
+ "These keys are supported:\n\n".
+ " - **source**: The PHID of the file.\n".
+ " - **width**: The width of the image in pixel.\n".
+ " - **height**: The height of the image in pixel."
+ ))
+ ->setLocked(true)
+ ->addExample($faviconexample, pht('Basic Example')),
$this->newOption('ui.footer-items', $footer_type, array())
->setSummary(
pht(
@@ -84,7 +104,7 @@
" - `href` Optionally, the link target of the item. You can ".
" omit this if you just want a piece of text, like a copyright ".
" notice."))
- ->addExample($example, pht('Basic Example')),
+ ->addExample($footerexample, pht('Basic Example')),
);
}

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 19, 11:35 (17 h, 56 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
977598
Default Alt Text
D25615.1732016119.diff (2 KB)

Event Timeline