Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F2627349
D25175.1731971047.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Award Token
Flag For Later
Advanced/Developer...
View Handle
View Hovercard
Size
1 KB
Referenced Files
None
Subscribers
None
D25175.1731971047.diff
View Options
diff --git a/src/applications/auth/constants/PhabricatorCookies.php b/src/applications/auth/constants/PhabricatorCookies.php
--- a/src/applications/auth/constants/PhabricatorCookies.php
+++ b/src/applications/auth/constants/PhabricatorCookies.php
@@ -164,7 +164,7 @@
// Old cookies look like: /uri
// New cookies look like: timestamp,/uri
- if (!strlen($cookie)) {
+ if (!phutil_nonempty_string($cookie)) {
return null;
}
diff --git a/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php b/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
--- a/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
+++ b/src/applications/people/cache/PhabricatorUserProfileImageCacheType.php
@@ -91,6 +91,9 @@
}
public function isRawCacheDataValid(PhabricatorUser $user, $key, $data) {
+ if ($data === null) {
+ return false;
+ }
$parts = explode(',', $data, 2);
$version = reset($parts);
return ($version === $this->getCacheVersion($user));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 18, 23:04 (11 h, 24 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
976959
Default Alt Text
D25175.1731971047.diff (1 KB)
Attached To
Mode
D25175: Fix PHP 8.1 "strlen(null)" and "explode()" exceptions which block rendering Administrator Account Creation page
Attached
Detach File
Event Timeline
Log In to Comment