Page MenuHomePhorge
Files F2567548

D25518.1729327747.diff
No OneTemporary
Actions

D25518.1729327747.diff
View Options

diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
--- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
@@ -143,6 +143,7 @@
->setDescription(pht('Search for tasks closed by certain users.')),
id(new PhabricatorSearchIntField())
->setLabel(pht('Page Size'))
+ ->setDefaultValue(100) // default limit defined in parent class
->setKey('limit'),
);
}
diff --git a/src/applications/search/field/PhabricatorSearchField.php b/src/applications/search/field/PhabricatorSearchField.php
--- a/src/applications/search/field/PhabricatorSearchField.php
+++ b/src/applications/search/field/PhabricatorSearchField.php
@@ -13,6 +13,7 @@
private $conduitKey;
private $viewer;
private $value;
+ private $defaultValue;
private $label;
private $aliases = array();
private $errors = array();
@@ -283,7 +284,21 @@
}
protected function getDefaultValue() {
- return null;
+ return $this->defaultValue;
+ }
+
+ /**
+ * Set a default field value
+ *
+ * Set a default value for a search field.
+ * Overrides a potential field placeholder value.
+ *
+ * @param wild Default value to be displayed in the SearchEngine
+ * @return this
+ */
+ public function setDefaultValue($default_value) {
+ $this->defaultValue = $default_value;
+ return $this;
}
public function getValueForQuery($value) {
diff --git a/src/applications/search/field/PhabricatorSearchIntField.php b/src/applications/search/field/PhabricatorSearchIntField.php
--- a/src/applications/search/field/PhabricatorSearchIntField.php
+++ b/src/applications/search/field/PhabricatorSearchIntField.php
@@ -3,10 +3,6 @@
final class PhabricatorSearchIntField
extends PhabricatorSearchField {
- protected function getDefaultValue() {
- return null;
- }
-
protected function getValueFromRequest(AphrontRequest $request, $key) {
return $request->getInt($key);
}

File Metadata

Mime Type
text/plain
Expires
Sat, Oct 19, 08:49 (21 h, 21 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
932923
Default Alt Text
D25518.1729327747.diff (2 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0