Page MenuHomePhorge

D25336.1726918466.diff
No OneTemporary

D25336.1726918466.diff

diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -779,15 +779,15 @@
break;
case 'compare':
$uri = $this->getPathURI("/{$action}/");
- if (strlen($head)) {
+ if (phutil_nonempty_scalar($head)) {
$query['head'] = $head;
- } else if (strlen($raw_commit)) {
+ } else if (phutil_nonempty_scalar($raw_commit)) {
$query['commit'] = $raw_commit;
- } else if (strlen($raw_branch)) {
+ } else if (phutil_nonempty_scalar($raw_branch)) {
$query['head'] = $raw_branch;
}
- if (strlen($against)) {
+ if (phutil_nonempty_scalar($against)) {
$query['against'] = $against;
}
break;

File Metadata

Mime Type
text/plain
Expires
Sat, Sep 21, 11:34 (19 h, 44 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
893749
Default Alt Text
D25336.1726918466.diff (949 B)

Event Timeline